From: Martin Liska Date: Fri, 30 Oct 2020 10:23:11 +0000 (+0100) Subject: gcc-changelog: Handle situations like '* tree-vect-slp.c (): ' X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=63d0da8852553ec42d5256e9c96ee21d26e0c2cd;p=gcc.git gcc-changelog: Handle situations like '* tree-vect-slp.c (): ' contrib/ChangeLog: * gcc-changelog/git_commit.py: Handle empty groups in file description. * gcc-changelog/test_email.py: New test. * gcc-changelog/test_patches.txt: Likewise. --- diff --git a/contrib/gcc-changelog/git_commit.py b/contrib/gcc-changelog/git_commit.py index 5a9cc4c7563..1d0860cddd8 100755 --- a/contrib/gcc-changelog/git_commit.py +++ b/contrib/gcc-changelog/git_commit.py @@ -459,6 +459,13 @@ class GitCommit: msg = 'one space should follow asterisk' self.errors.append(Error(msg, line)) else: + content = m.group('content') + parts = content.split(':') + if len(parts) > 1: + for needle in ('()', '[]', '<>'): + if ' ' + needle in parts[0]: + msg = f'empty group "{needle}" found' + self.errors.append(Error(msg, line)) last_entry.lines.append(line) else: if last_entry.is_empty: diff --git a/contrib/gcc-changelog/test_email.py b/contrib/gcc-changelog/test_email.py index b6fbe6a5303..98f2ecd258d 100755 --- a/contrib/gcc-changelog/test_email.py +++ b/contrib/gcc-changelog/test_email.py @@ -365,3 +365,8 @@ class TestGccChangelog(unittest.TestCase): def test_square_and_lt_gt(self): email = self.from_patch_glob('0001-Check-for-more-missing') assert not email.errors + + def test_empty_parenthesis(self): + email = self.from_patch_glob('0001-tree-optimization-97633-fix') + assert len(email.errors) == 1 + assert email.errors[0].message == 'empty group "()" found' diff --git a/contrib/gcc-changelog/test_patches.txt b/contrib/gcc-changelog/test_patches.txt index 2bf5d1aefaa..148d020f23b 100644 --- a/contrib/gcc-changelog/test_patches.txt +++ b/contrib/gcc-changelog/test_patches.txt @@ -3193,5 +3193,46 @@ index fe18288..313f84d 100644 + -- +=== 0001-tree-optimization-97633-fix-SLP-scheduling-of-single.patch === +From c0bfd9672e19caf08e45afeb4277f848488ced2b Mon Sep 17 00:00:00 2001 +From: Richard Biener +Date: Fri, 30 Oct 2020 09:57:02 +0100 +Subject: [PATCH] tree-optimization/97633 - fix SLP scheduling of single-node + cycles + +This makes sure to update backedges in single-node cycles. + +2020-10-30 Richard Biener + + PR tree-optimization/97633 + * tree-vect-slp.c (): Update backedges in single-node cycles. + Optimize processing of externals. + + * g++.dg/vect/slp-pr97636.cc: New testcase. + * gcc.dg/vect/bb-slp-pr97633.c: Likewise. +--- + gcc/testsuite/g++.dg/vect/slp-pr97636.cc | 83 +++++++++++ + gcc/testsuite/gcc.dg/vect/bb-slp-pr97633.c | 27 ++++ + gcc/tree-vect-slp.c | 162 +++++++++++---------- + 3 files changed, 198 insertions(+), 74 deletions(-) + create mode 100644 gcc/testsuite/g++.dg/vect/slp-pr97636.cc + create mode 100644 gcc/testsuite/gcc.dg/vect/bb-slp-pr97633.c + +diff --git a/gcc/testsuite/g++.dg/vect/slp-pr97636.cc b/gcc/testsuite/g++.dg/vect/slp-pr97636.cc +new file mode 100644 +index 00000000000..012342004f1 +--- /dev/null ++++ b/gcc/testsuite/g++.dg/vect/slp-pr97636.cc +@@ -0,0 +1 @@ ++ +diff --git a/gcc/tree-vect-slp.c b/gcc/tree-vect-slp.c +index 5d69a98c2a9..714e50697bd 100644 +--- a/gcc/tree-vect-slp.c ++++ b/gcc/tree-vect-slp.c +@@ -1 +1,2 @@ + ++ +-- + 2.7.4