From: Alan Modra <amodra@gmail.com>
Date: Thu, 27 Apr 2017 01:36:33 +0000 (+0930)
Subject: Clear dynstr_index when forcing symbols local
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=641338d8e9b62bde9672f13f0dca2324b61e46e2;p=binutils-gdb.git

Clear dynstr_index when forcing symbols local

This is really just cosmetic, but it does protect a little from
accidentally reading a stale value.

	* elflink.c (_bfd_elf_link_hash_hide_symbol): Clear dynstr_index
	when force_local.
---

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 6cda710ff2a..c870cc712a6 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,8 @@
+2017-04-27  Alan Modra  <amodra@gmail.com>
+
+	* elflink.c (_bfd_elf_link_hash_hide_symbol): Clear dynstr_index
+	when force_local.
+
 2017-04-27  Alan Modra  <amodra@gmail.com>
 
 	* elf32-ppc.c (UNDEFWEAK_NO_DYNAMIC_RELOC): Define.
diff --git a/bfd/elflink.c b/bfd/elflink.c
index 73af7634434..59300b7cde7 100644
--- a/bfd/elflink.c
+++ b/bfd/elflink.c
@@ -7295,9 +7295,10 @@ _bfd_elf_link_hash_hide_symbol (struct bfd_link_info *info,
       h->forced_local = 1;
       if (h->dynindx != -1)
 	{
-	  h->dynindx = -1;
 	  _bfd_elf_strtab_delref (elf_hash_table (info)->dynstr,
 				  h->dynstr_index);
+	  h->dynindx = -1;
+	  h->dynstr_index = 0;
 	}
     }
 }