From: Oliver McFadden Date: Thu, 7 Jun 2007 13:20:27 +0000 (+0000) Subject: r300: Removed a "don't think this is needed" comment, it actually is needed. X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=65b45d6d583cce20c8e025643f8e042b2ae6e778;p=mesa.git r300: Removed a "don't think this is needed" comment, it actually is needed. According to the comment you do not need to setup INPUT_CNTL when using vertex buffers. However, not doing so results in a lockup. --- diff --git a/src/mesa/drivers/dri/r300/r300_emit.c b/src/mesa/drivers/dri/r300/r300_emit.c index c1b795f8149..4670c28a02f 100644 --- a/src/mesa/drivers/dri/r300/r300_emit.c +++ b/src/mesa/drivers/dri/r300/r300_emit.c @@ -484,14 +484,12 @@ int r300EmitArrays(GLcontext * ctx) ((drm_r300_cmd_header_t *) rmesa->hw.vir[0].cmd)->packet0.count = r300VAPInputRoute0(&rmesa->hw.vir[0].cmd[R300_VIR_CNTL_0], vb->AttribPtr, inputs, tab, nr); - R300_STATECHANGE(rmesa, vir[1]); ((drm_r300_cmd_header_t *) rmesa->hw.vir[1].cmd)->packet0.count = r300VAPInputRoute1(&rmesa->hw.vir[1].cmd[R300_VIR_CNTL_0], swizzle, nr); /* Setup INPUT_CNTL. */ - /* I don't think this is needed for vertex buffers, but it doesn't hurt anything */ R300_STATECHANGE(rmesa, vic); rmesa->hw.vic.cmd[R300_VIC_CNTL_0] = r300VAPInputCntl0(ctx, InputsRead); rmesa->hw.vic.cmd[R300_VIC_CNTL_1] = r300VAPInputCntl1(ctx, InputsRead);