From: Jakub Jelinek <jakub@redhat.com>
Date: Thu, 11 Feb 2016 22:55:02 +0000 (+0100)
Subject: re PR c/69768 (Bogus -Waddress warning)
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=66756373c1940650568173b6d9c32325429bfc34;p=gcc.git

re PR c/69768 (Bogus -Waddress warning)

	PR c/69768
	* c-typeck.c (parser_build_binary_op): Strip nops from integer_zerop
	arguments for -Waddress warning.

	* typeck.c (cp_build_binary_op): cp_fully_fold integer_zerop
	arguments for -Waddress warning.  Fix up formatting.

	* c-c++-common/Waddress-1.c: New test.

From-SVN: r233357
---

diff --git a/gcc/c/ChangeLog b/gcc/c/ChangeLog
index 931e51d03d8..b595b81676d 100644
--- a/gcc/c/ChangeLog
+++ b/gcc/c/ChangeLog
@@ -1,3 +1,9 @@
+2016-02-11  Jakub Jelinek  <jakub@redhat.com>
+
+	PR c/69768
+	* c-typeck.c (parser_build_binary_op): Strip nops from integer_zerop
+	arguments for -Waddress warning.
+
 2016-02-04  Jakub Jelinek  <jakub@redhat.com>
 
 	PR c/69669
diff --git a/gcc/c/c-typeck.c b/gcc/c/c-typeck.c
index 65925cbc8e7..82efacf1389 100644
--- a/gcc/c/c-typeck.c
+++ b/gcc/c/c-typeck.c
@@ -3597,8 +3597,10 @@ parser_build_binary_op (location_t location, enum tree_code code,
      of testing for equality or inequality of a string literal with NULL.  */
   if (code == EQ_EXPR || code == NE_EXPR)
     {
-      if ((code1 == STRING_CST && !integer_zerop (arg2.value))
-	  || (code2 == STRING_CST && !integer_zerop (arg1.value)))
+      if ((code1 == STRING_CST
+	   && !integer_zerop (tree_strip_nop_conversions (arg2.value)))
+	  || (code2 == STRING_CST
+	      && !integer_zerop (tree_strip_nop_conversions (arg1.value))))
 	warning_at (location, OPT_Waddress,
 		    "comparison with string literal results in unspecified behavior");
     }
diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog
index 7a80565e059..1b4ebd3f495 100644
--- a/gcc/cp/ChangeLog
+++ b/gcc/cp/ChangeLog
@@ -1,3 +1,9 @@
+2016-02-11  Jakub Jelinek  <jakub@redhat.com>
+
+	PR c/69768
+	* typeck.c (cp_build_binary_op): cp_fully_fold integer_zerop
+	arguments for -Waddress warning.  Fix up formatting.
+
 2016-02-11  Paolo Carlini  <paolo.carlini@oracle.com>
 
 	PR c++/68726
diff --git a/gcc/cp/typeck.c b/gcc/cp/typeck.c
index c9fa1129008..3a247d850c2 100644
--- a/gcc/cp/typeck.c
+++ b/gcc/cp/typeck.c
@@ -4487,9 +4487,12 @@ cp_build_binary_op (location_t location,
 	warning (OPT_Wfloat_equal,
 		 "comparing floating point with == or != is unsafe");
       if ((complain & tf_warning)
-	  && ((TREE_CODE (orig_op0) == STRING_CST && !integer_zerop (op1))
-	      || (TREE_CODE (orig_op1) == STRING_CST && !integer_zerop (op0))))
-	warning (OPT_Waddress, "comparison with string literal results in unspecified behaviour");
+	  && ((TREE_CODE (orig_op0) == STRING_CST
+	       && !integer_zerop (cp_fully_fold (op1)))
+	      || (TREE_CODE (orig_op1) == STRING_CST
+		  && !integer_zerop (cp_fully_fold (op0)))))
+	warning (OPT_Waddress, "comparison with string literal results "
+			       "in unspecified behaviour");
 
       build_type = boolean_type_node;
       if ((code0 == INTEGER_TYPE || code0 == REAL_TYPE
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index c99f7639760..baf28f5339f 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2016-02-11  Jakub Jelinek  <jakub@redhat.com>
+
+	PR c/69768
+	* c-c++-common/Waddress-1.c: New test.
+
 2016-02-11  Andre Vehreschild  <vehre@gcc.gnu.org>
 
 	PR fortran/69296
diff --git a/gcc/testsuite/c-c++-common/Waddress-1.c b/gcc/testsuite/c-c++-common/Waddress-1.c
new file mode 100644
index 00000000000..a5d128fd531
--- /dev/null
+++ b/gcc/testsuite/c-c++-common/Waddress-1.c
@@ -0,0 +1,15 @@
+/* PR c/69768 */
+/* { dg-do compile } */
+/* { dg-options "-Waddress" } */
+
+static int e;
+
+int
+foo ()
+{
+  return "foo1" != (void *) 0	/* { dg-bogus "comparison with string literal results in unspecified behaviou?r" } */
+	 && "foo2" != (const char *) ((void *) 0)	/* { dg-bogus "comparison with string literal results in unspecified behaviou?r" } */
+	 && "foo3" != (const char *) ((void *) (10 - 10))	/* { dg-bogus "comparison with string literal results in unspecified behaviou?r" } */
+	 && "foo4" != (const char *) ((void *) (&e - &e))	/* { dg-warning "comparison with string literal results in unspecified behaviou?r" "" { target c } } */
+	 && "foo5" != "foo6";	/* { dg-warning "comparison with string literal results in unspecified behaviou?r" } */
+}