From: Tom Tromey <tromey@adacore.com>
Date: Mon, 17 Apr 2023 19:36:51 +0000 (-0600)
Subject: Remove some unnecessary casts from ada-lang.c
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=66cf935043fba24919043a62b430da9c51609133;p=binutils-gdb.git

Remove some unnecessary casts from ada-lang.c

I noticed some unnecessary casts to LONGEST in ada-lang.c.  This patch
removes the ones I think are very clearly not needed.  I'm checking
this in as obvious.
---

diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c
index a3fc88a3488..97e03f78d5d 100644
--- a/gdb/ada-lang.c
+++ b/gdb/ada-lang.c
@@ -3286,7 +3286,7 @@ ada_array_bound_from_type (struct type *arr_type, int n, int which)
     arr_type = decode_constrained_packed_array_type (arr_type);
 
   if (arr_type == NULL || !ada_is_simple_array_type (arr_type))
-    return (LONGEST) - which;
+    return - which;
 
   if (arr_type->code () == TYPE_CODE_PTR)
     type = arr_type->target_type ();
@@ -3319,10 +3319,9 @@ ada_array_bound_from_type (struct type *arr_type, int n, int which)
       index_type = elt_type->index_type ();
     }
 
-  return
-    (LONGEST) (which == 0
-	       ? ada_discrete_type_low_bound (index_type)
-	       : ada_discrete_type_high_bound (index_type));
+  return (which == 0
+	  ? ada_discrete_type_low_bound (index_type)
+	  : ada_discrete_type_high_bound (index_type));
 }
 
 /* Given that arr is an array value, returns the lower bound of the
@@ -10113,7 +10112,7 @@ ada_unop_in_range (struct type *expect_type,
       lim_warning (_("Membership test incompletely implemented; "
 		     "always returns true"));
       type = language_bool_type (exp->language_defn, exp->gdbarch);
-      return value_from_longest (type, (LONGEST) 1);
+      return value_from_longest (type, 1);
 
     case TYPE_CODE_RANGE:
       arg2 = value_from_longest (type,
@@ -10223,7 +10222,7 @@ ada_equal_binop (struct type *expect_type,
   if (op == BINOP_NOTEQUAL)
     tem = !tem;
   struct type *type = language_bool_type (exp->language_defn, exp->gdbarch);
-  return value_from_longest (type, (LONGEST) tem);
+  return value_from_longest (type, tem);
 }
 
 /* A helper function for TERNOP_SLICE.  */