From: Brian Date: Fri, 28 Dec 2007 02:17:41 +0000 (-0700) Subject: fix a mem leak, document another existing leak X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=6883e02a5cab528623e11ad7717f1052ab2e031d;p=mesa.git fix a mem leak, document another existing leak --- diff --git a/src/mesa/pipe/cso_cache/cso_hash.c b/src/mesa/pipe/cso_cache/cso_hash.c index fe033c9e912..0338cb3b474 100644 --- a/src/mesa/pipe/cso_cache/cso_hash.c +++ b/src/mesa/pipe/cso_cache/cso_hash.c @@ -101,8 +101,15 @@ static void *cso_data_allocate_node(struct cso_hash_data *hash) return malloc(hash->nodeSize); } -static void cso_data_free_node(void *node) +static void cso_data_free_node(struct cso_node *node) { + /* XXX still a leak here. + * Need to cast value ptr to original cso type, then free the + * driver-specific data hanging off of it. For example: + struct cso_sampler *csamp = (struct cso_sampler *) node->value; + free(csamp->data); + */ + free(node->value); free(node); }