From: Indu Bhagat Date: Fri, 13 Jan 2023 19:15:43 +0000 (-0800) Subject: libsframe: replace an strncat with strcat X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=68e0003e12184a9bc13e06d35b6bb168f5f27ed3;p=binutils-gdb.git libsframe: replace an strncat with strcat Calling strncat with the size of the src string is not so meaningful. The length argument to strncat should specify the remaining bytes bytes in the destination; although in this case, it appears to be unncessary altogether to use strncat in the first place. libsframe/ * sframe-dump.c (dump_sframe_func_with_fres): Use of strcat is just as fine. --- diff --git a/libsframe/sframe-dump.c b/libsframe/sframe-dump.c index 320555a0a51..5417a16f48c 100644 --- a/libsframe/sframe-dump.c +++ b/libsframe/sframe-dump.c @@ -176,8 +176,7 @@ dump_sframe_func_with_fres (sframe_decoder_ctx *sfd_ctx, const char *ra_mangled_p_str = ((sframe_fre_get_ra_mangled_p (sfd_ctx, &fre, &err[2])) ? "[s]" : " "); - size_t ra_mangled_p_str_size = strlen (ra_mangled_p_str); - strncat (temp, ra_mangled_p_str, ra_mangled_p_str_size); + strcat (temp, ra_mangled_p_str); printf ("%-13s", temp); } }