From: Nathan Sidwell <nathan@codesourcery.com>
Date: Fri, 30 Oct 2009 10:46:00 +0000 (+0000)
Subject: 	* ld-elfcomm/elfcomm.exp: Compile with -fcommon.
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=698be22afe187e449bbfc42f0b664ff5b3c44ff8;p=binutils-gdb.git

	* ld-elfcomm/elfcomm.exp: Compile with -fcommon.
---

diff --git a/ld/testsuite/ChangeLog b/ld/testsuite/ChangeLog
index 28829c63251..e634cceb718 100644
--- a/ld/testsuite/ChangeLog
+++ b/ld/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2009-10-30  Mark Mitchell  <mark@codesourcery.com>
+
+	* ld-elfcomm/elfcomm.exp: Compile with -fcommon.
+
 2009-10-28  Johan Kristell  <johankri@axis.com>
 
 	* ld-cris/dso12-pltdis.d: New test.
diff --git a/ld/testsuite/ld-elfcomm/elfcomm.exp b/ld/testsuite/ld-elfcomm/elfcomm.exp
index 213a821bc35..5ece03fd8f4 100644
--- a/ld/testsuite/ld-elfcomm/elfcomm.exp
+++ b/ld/testsuite/ld-elfcomm/elfcomm.exp
@@ -176,9 +176,10 @@ proc assembler_generates_commons {} {
     return 1
 }
 
-
-if {   ![ld_compile "$CC $CFLAGS" $srcdir/$subdir/common1a.c tmpdir/common1a.o]
-    || ![ld_compile "$CC $CFLAGS" $srcdir/$subdir/common1b.c tmpdir/common1b.o] } {
+# Explicitly use "-fcommon" so that even if $CFLAGS includes
+# "-fno-common", these tests are compiled as expected.
+if {   ![ld_compile "$CC $CFLAGS -fcommon" $srcdir/$subdir/common1a.c tmpdir/common1a.o]
+    || ![ld_compile "$CC $CFLAGS -fcommon" $srcdir/$subdir/common1b.c tmpdir/common1b.o] } {
     unresolved $test1
     return
 }