From: Stefan Sørensen Date: Tue, 24 Feb 2015 15:47:34 +0000 (+0100) Subject: fs: Bail out on errors in fakeroot script X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=6b577b3c3adf7de2582985160ab2906c8dabf22c;p=buildroot.git fs: Bail out on errors in fakeroot script Currently, the generated fakeroot script has no error checking causing make to continue building even if some of the fakeroot script commands have failed. This can cause e.g. using an invalid device tables to go unnoticed. So add a "set -e" to the start of the fakeroot script so it will exit with a failure code as soon as one of the script commands fails. Signed-off-by: Stefan Sørensen Acked-by: "Yann E. MORIN" Signed-off-by: Thomas Petazzoni --- diff --git a/fs/common.mk b/fs/common.mk index 13bf4ad77f..1d3926f98c 100644 --- a/fs/common.mk +++ b/fs/common.mk @@ -72,6 +72,7 @@ $$(BINARIES_DIR)/rootfs.$(1): target-finalize $$(ROOTFS_$(2)_DEPENDENCIES) rm -f $$(FAKEROOT_SCRIPT) rm -f $$(TARGET_DIR_WARNING_FILE) rm -f $$(USERS_TABLE) + echo "set -e" >> $$(FAKEROOT_SCRIPT) echo "chown -h -R 0:0 $$(TARGET_DIR)" >> $$(FAKEROOT_SCRIPT) ifneq ($$(ROOTFS_DEVICE_TABLES),) cat $$(ROOTFS_DEVICE_TABLES) > $$(FULL_DEVICE_TABLE)