From: Iago Toral Quiroga <itoral@igalia.com>
Date: Mon, 28 Sep 2015 10:59:33 +0000 (+0200)
Subject: glsl: Fix unused value warning reported by Coverity
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=6bf718fec22f605702c7d15503d4dbc3c2be35e6;p=mesa.git

glsl: Fix unused value warning reported by Coverity

We don't use param in this part of the code, so no point in advancing
the pointer forward:

>>>     CID 1324983:  Code maintainability issues  (UNUSED_VALUE)
>>>     Assigning value from "param->get_next()" to "param" here, but that stored value is overwritten before it can be used.

Reviewed-by: Kristian Høgsberg <krh@bitplanet.net>
---

diff --git a/src/glsl/lower_ubo_reference.cpp b/src/glsl/lower_ubo_reference.cpp
index 31885cd3dec..4e09b080e62 100644
--- a/src/glsl/lower_ubo_reference.cpp
+++ b/src/glsl/lower_ubo_reference.cpp
@@ -1099,13 +1099,11 @@ lower_ubo_reference_visitor::lower_ssbo_atomic_intrinsic(ir_call *ir)
 
    const glsl_type *type = deref->type->base_type == GLSL_TYPE_INT ?
       glsl_type::int_type : glsl_type::uint_type;
-   param = param->get_next();
    sig_param = new(mem_ctx)
          ir_variable(type, "data1", ir_var_function_in);
    sig_params.push_tail(sig_param);
 
    if (param_count == 3) {
-      param = param->get_next();
       sig_param = new(mem_ctx)
             ir_variable(type, "data2", ir_var_function_in);
       sig_params.push_tail(sig_param);