From: Kenneth Graunke Date: Mon, 9 Sep 2013 18:11:03 +0000 (-0700) Subject: i965/vec4: Only zero out unused message components when there are any. X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=6c3db2167c64ecf2366862f15f8e2d4a91f1028c;p=mesa.git i965/vec4: Only zero out unused message components when there are any. Otherwise, coordinates with four components would result in a MOV with a destination writemask that has no channels enabled: mov(8) g115<1>.F 0D { align16 WE_normal NoDDChk 1Q }; At best, this is stupid: we emit code that shouldn't do anything. Worse, it apparently causes GPU hangs (observable with Chris's textureGather test on CubeArrays.) Signed-off-by: Kenneth Graunke Cc: Chris Forbes Cc: mesa-stable@lists.freedesktop.org --- diff --git a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp index ca52fd39c87..8cfe4e3d930 100644 --- a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp +++ b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp @@ -2245,8 +2245,10 @@ vec4_visitor::visit(ir_texture *ir) emit(MOV(dst_reg(MRF, param_base, ir->coordinate->type, coord_mask), coordinate)); } - emit(MOV(dst_reg(MRF, param_base, ir->coordinate->type, zero_mask), - src_reg(0))); + if (zero_mask != 0) { + emit(MOV(dst_reg(MRF, param_base, ir->coordinate->type, zero_mask), + src_reg(0))); + } /* Load the shadow comparitor */ if (ir->shadow_comparitor && ir->op != ir_txd) { emit(MOV(dst_reg(MRF, param_base + 1, ir->shadow_comparitor->type,