From: Jim Blandy Date: Tue, 14 Sep 2004 03:01:48 +0000 (+0000) Subject: * valops.c (value_assign): 'use_buffer' is initialized to zero, X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=6c4182ddc9e707f2bb12ee248458e3082ad28ce4;p=binutils-gdb.git * valops.c (value_assign): 'use_buffer' is initialized to zero, and never assigned to. Delete it, and the 'if (use_buffer)' clauses. Delete 'raw_buffer', since it is now unused. --- diff --git a/gdb/ChangeLog b/gdb/ChangeLog index a832382457f..234e3790028 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -3,6 +3,10 @@ * valops.c (value_assign): Move 'buffer' to the enclosing block, so that its storage isn't referenced after its lifetime ends. + * valops.c (value_assign): 'use_buffer' is initialized to zero, + and never assigned to. Delete it, and the 'if (use_buffer)' + clauses. Delete 'raw_buffer', since it is now unused. + 2004-09-13 Andrew Cagney * configure.in (frags): Replace TM_FILE with DEPRECATED_TM_FILE. diff --git a/gdb/valops.c b/gdb/valops.c index 6e825ac382f..575c9a335ea 100644 --- a/gdb/valops.c +++ b/gdb/valops.c @@ -525,8 +525,6 @@ value_assign (struct value *toval, struct value *fromval) { struct type *type; struct value *val; - char raw_buffer[MAX_REGISTER_SIZE]; - int use_buffer = 0; struct frame_id old_frame; if (!toval->modifiable) @@ -591,12 +589,6 @@ value_assign (struct value *toval, struct value *fromval) changed_addr = VALUE_ADDRESS (toval) + VALUE_OFFSET (toval); dest_buffer = buffer; } - else if (use_buffer) - { - changed_addr = VALUE_ADDRESS (toval) + VALUE_OFFSET (toval); - changed_len = use_buffer; - dest_buffer = raw_buffer; - } else { changed_addr = VALUE_ADDRESS (toval) + VALUE_OFFSET (toval); @@ -683,8 +675,6 @@ value_assign (struct value *toval, struct value *fromval) modify_field (buffer + byte_offset, value_as_long (fromval), VALUE_BITPOS (toval), VALUE_BITSIZE (toval)); - else if (use_buffer) - memcpy (buffer + VALUE_OFFSET (toval), raw_buffer, use_buffer); else memcpy (buffer + byte_offset, VALUE_CONTENTS (fromval), TYPE_LENGTH (type));