From: Samuel Pitoiset Date: Fri, 20 Jul 2018 16:48:07 +0000 (+0200) Subject: radv: fix a memleak for merged shaders on GFX9 X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=6e32d9e7b0945268b844ab2397ab3c9924136d3a;p=mesa.git radv: fix a memleak for merged shaders on GFX9 modules[i] can be NULL for merged shaders but we have to free the NIR code. radv_can_dump_shader_stats() already handles if modules[i] is NULL, no need to check it twice. Cc: mesa-stable@lists.freedesktop.org Signed-off-by: Samuel Pitoiset Reviewed-by: Bas Nieuwenhuizen --- diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 27e13a2251c..545b618b7c2 100644 --- a/src/amd/vulkan/radv_pipeline.c +++ b/src/amd/vulkan/radv_pipeline.c @@ -2160,7 +2160,7 @@ void radv_create_shaders(struct radv_pipeline *pipeline, for (int i = 0; i < MESA_SHADER_STAGES; ++i) { free(codes[i]); - if (modules[i]) { + if (nir[i]) { if (!pipeline->device->keep_shader_info) ralloc_free(nir[i]);