From: Eric Anholt <eric@anholt.net>
Date: Wed, 20 Apr 2016 21:11:04 +0000 (-0700)
Subject: vc4: Don't try to blit from MSAA surfaces with mismatched width to dst.
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=6eabdb8959eef9802caa618e7390eb5beeca226a;p=mesa.git

vc4: Don't try to blit from MSAA surfaces with mismatched width to dst.

I had made the previous blit fix non-MSAA only because I was thinking
about how the hardware infers stride from the RENDERING_CONFIG packet.
However, I'm also inferring the stride for both MSAA src and dst in
vc4_render_cl.c from the width argument in the ioctl.

Fixes 15 EXT_framebuffer_multisample piglit tests.
---

diff --git a/src/gallium/drivers/vc4/vc4_blit.c b/src/gallium/drivers/vc4/vc4_blit.c
index 128a3e50ee2..029170a5dc5 100644
--- a/src/gallium/drivers/vc4/vc4_blit.c
+++ b/src/gallium/drivers/vc4/vc4_blit.c
@@ -93,20 +93,23 @@ vc4_tile_blit(struct pipe_context *pctx, const struct pipe_blit_info *info)
          * destination surface) to determine the stride.  This may be wrong
          * when reading from texture miplevels > 0, which are stored in
          * POT-sized areas.  For MSAA, the tile addresses are computed
-         * explicitly by the RCL.
+         * explicitly by the RCL, but still use the destination width to
+         * determine the stride (which could be fixed by explicitly supplying
+         * it in the ABI).
          */
-        if (info->src.resource->nr_samples <= 1) {
-                struct vc4_resource *rsc = vc4_resource(info->src.resource);
+        struct vc4_resource *rsc = vc4_resource(info->src.resource);
 
-                uint32_t stride = dst_surface_width * rsc->cpp;
-                if (rsc->slices[info->src.level].tiling == VC4_TILING_FORMAT_T)
-                        stride = align(stride, 128);
-                else
-                        stride = align(stride, 16);
+        uint32_t stride;
 
-                if (stride != rsc->slices[info->src.level].stride)
-                        return false;
-        }
+        if (info->src.resource->nr_samples > 1)
+                stride = align(dst_surface_width, 32) * 4 * rsc->cpp;
+        else if (rsc->slices[info->src.level].tiling == VC4_TILING_FORMAT_T)
+                stride = align(dst_surface_width * rsc->cpp, 128);
+        else
+                stride = align(dst_surface_width * rsc->cpp, 16);
+
+        if (stride != rsc->slices[info->src.level].stride)
+                return false;
 
         if (info->dst.resource->format != info->src.resource->format)
                 return false;