From: Elena Zannoni <ezannoni@kwikemart.cygnus.com>
Date: Mon, 26 Mar 2001 02:50:46 +0000 (+0000)
Subject: 2001-03-25  Elena Zannoni  <ezannoni@kwikemart.cygnus.com>
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=6ec4c4bd0ef272bc731317621ce4482eb801e4ca;p=binutils-gdb.git

2001-03-25  Elena Zannoni  <ezannoni@kwikemart.cygnus.com>

	From  Andrew Cagney  <ac131313@redhat.com>

        * coffread.c: Include "gdb_assert.h".
	(coff_symtab_read): Cast the integer s_sclass to a long before
 	casting it to a pointer.
---

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 38efd9f4c0b..f8538bdd832 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,11 @@
+2001-03-25  Elena Zannoni  <ezannoni@kwikemart.cygnus.com>
+
+	From  Andrew Cagney  <ac131313@redhat.com>
+
+        * coffread.c: Include "gdb_assert.h".
+	(coff_symtab_read): Cast the integer s_sclass to a long before
+ 	casting it to a pointer.
+
 2001-03-25  Elena Zannoni  <ezannoni@kwikemart.cygnus.com>
 
 	From  Andrew Cagney  <ac131313@redhat.com>
diff --git a/gdb/coffread.c b/gdb/coffread.c
index 7f775de49f2..a343a6825d5 100644
--- a/gdb/coffread.c
+++ b/gdb/coffread.c
@@ -43,6 +43,7 @@
 #include "stabsread.h"
 #include "complaints.h"
 #include "target.h"
+#include "gdb_assert.h"
 
 extern void _initialize_coffread (void);
 
@@ -966,9 +967,15 @@ coff_symtab_read (long symtab_offset, unsigned int nsyms,
 	      {
 		struct minimal_symbol *msym;
 
+ 		/* FIXME: cagney/2001-02-01: The nasty (int) -> (long)
+                   -> (void*) cast is to ensure that that the value of
+                   cs->c_sclass can be correctly stored in a void
+                   pointer in MSYMBOL_INFO.  Better solutions
+                   welcome. */
+		gdb_assert (sizeof (void *) >= sizeof (cs->c_sclass));
 		msym = prim_record_minimal_symbol_and_info
-		  (cs->c_name, tmpaddr, ms_type, (char *) cs->c_sclass, sec,
-		   NULL, objfile);
+		  (cs->c_name, tmpaddr, ms_type, (void *) (long) cs->c_sclass,
+		   sec, NULL, objfile);
 #ifdef COFF_MAKE_MSYMBOL_SPECIAL
 		if (msym)
 		  COFF_MAKE_MSYMBOL_SPECIAL (cs->c_sclass, msym);