From: Alyssa Rosenzweig Date: Thu, 9 Jul 2020 19:21:32 +0000 (-0400) Subject: panfrost: Fix sRGB clear colour packing X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=6ffebfbff8a6bc8b4ec14946037378c45136223b;p=mesa.git panfrost: Fix sRGB clear colour packing It should be sRGB transformed first, which the generic path handles but the RGBA8 special path does not. Signed-off-by: Alyssa Rosenzweig Part-of: --- diff --git a/.gitlab-ci/deqp-panfrost-t860-fails.txt b/.gitlab-ci/deqp-panfrost-t860-fails.txt index 26dda2d4439..93de93424e6 100644 --- a/.gitlab-ci/deqp-panfrost-t860-fails.txt +++ b/.gitlab-ci/deqp-panfrost-t860-fails.txt @@ -15,9 +15,6 @@ dEQP-GLES3.functional.fbo.blit.rect.nearest_consistency_min_reverse_src_dst_x dEQP-GLES3.functional.fbo.blit.rect.nearest_consistency_min_reverse_src_dst_y dEQP-GLES3.functional.fbo.blit.rect.nearest_consistency_min_reverse_src_x dEQP-GLES3.functional.fbo.blit.rect.nearest_consistency_min_reverse_src_y -dEQP-GLES3.functional.fbo.color.repeated_clear.blit.rbo.srgb8_alpha8 -dEQP-GLES3.functional.fbo.color.repeated_clear.blit.tex2d.srgb8_alpha8 -dEQP-GLES3.functional.fbo.color.repeated_clear.sample.tex2d.srgb8_alpha8 dEQP-GLES3.functional.fbo.invalidate.sub.unbind_blit_msaa_color dEQP-GLES3.functional.fbo.invalidate.sub.unbind_blit_msaa_depth dEQP-GLES3.functional.fbo.invalidate.sub.unbind_blit_msaa_stencil diff --git a/src/gallium/drivers/panfrost/pan_job.c b/src/gallium/drivers/panfrost/pan_job.c index 365b4ccdb3a..c495d6133e6 100644 --- a/src/gallium/drivers/panfrost/pan_job.c +++ b/src/gallium/drivers/panfrost/pan_job.c @@ -1324,7 +1324,7 @@ pan_pack_color(uint32_t *packed, const union pipe_color_union *color, enum pipe_ const struct util_format_description *desc = util_format_description(format); - if (util_format_is_rgba8_variant(desc)) { + if (util_format_is_rgba8_variant(desc) && desc->colorspace != UTIL_FORMAT_COLORSPACE_SRGB) { pan_pack_color_32(packed, ((uint32_t) float_to_ubyte(clear_alpha) << 24) | ((uint32_t) float_to_ubyte(color->f[2]) << 16) |