From: Kenneth Graunke Date: Thu, 16 Mar 2017 00:53:44 +0000 (-0700) Subject: i965: Use aubinator/genxml for INTEL_DEBUG=bat state decoding. X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=705c38e96f1ea732dd85c72c85f988171697867c;p=mesa.git i965: Use aubinator/genxml for INTEL_DEBUG=bat state decoding. This deletes all of our handwritten code in favor of autogenerated genxml-based decoding. This should be much more usable, as the old code isn't entirely accurate - we updated some things for new generations, but not everything. Aubinator has one annoying limitation: it has no idea how many entries to print when encountering e.g. 3DSTATE_BINDING_TABLE_POINTERS_VS. It picks an arbitrary number, which may skip decoding valid data, and may print extra garbage entries. We do a better job here by making brw_state_batch track the size of the data stored at a particular batchbuffer offset. Then, we can divide by the structure size to obtain the exact number of entries. Reviewed-by: Lionel Landwerlin Reviewed-by: Emil Velikov --- diff --git a/src/mesa/drivers/dri/i965/Makefile.sources b/src/mesa/drivers/dri/i965/Makefile.sources index 6456df5dc01..23d0422cf48 100644 --- a/src/mesa/drivers/dri/i965/Makefile.sources +++ b/src/mesa/drivers/dri/i965/Makefile.sources @@ -55,7 +55,6 @@ i965_FILES = \ brw_sf.h \ brw_sf_state.c \ brw_state_batch.c \ - brw_state_dump.c \ brw_state.h \ brw_state_upload.c \ brw_structs.h \ diff --git a/src/mesa/drivers/dri/i965/brw_context.h b/src/mesa/drivers/dri/i965/brw_context.h index 6f4dbe81c37..a119d79a7e5 100644 --- a/src/mesa/drivers/dri/i965/brw_context.h +++ b/src/mesa/drivers/dri/i965/brw_context.h @@ -482,6 +482,9 @@ struct intel_batchbuffer { uint32_t *map_next; int reloc_count; } saved; + + /** Map from batch offset to brw_state_batch data (with DEBUG_BATCH) */ + struct hash_table *state_batch_sizes; }; #define BRW_MAX_XFB_STREAMS 4 @@ -1173,15 +1176,6 @@ struct brw_context const struct brw_tracked_state render_atoms[76]; const struct brw_tracked_state compute_atoms[11]; - /* If (INTEL_DEBUG & DEBUG_BATCH) */ - struct { - uint32_t offset; - uint32_t size; - enum aub_state_struct_type type; - int index; - } *state_batch_list; - int state_batch_count; - uint32_t render_target_format[MESA_FORMAT_COUNT]; bool format_supported_as_render_target[MESA_FORMAT_COUNT]; @@ -1345,11 +1339,6 @@ void brw_store_data_imm32(struct brw_context *brw, drm_intel_bo *bo, void brw_store_data_imm64(struct brw_context *brw, drm_intel_bo *bo, uint32_t offset, uint64_t imm); -/*====================================================================== - * brw_state_dump.c - */ -void brw_debug_batch(struct brw_context *brw); - /*====================================================================== * intel_tex_validate.c */ diff --git a/src/mesa/drivers/dri/i965/brw_state.h b/src/mesa/drivers/dri/i965/brw_state.h index 65e64a570c0..1eb2a0d0cb6 100644 --- a/src/mesa/drivers/dri/i965/brw_state.h +++ b/src/mesa/drivers/dri/i965/brw_state.h @@ -261,6 +261,8 @@ void *__brw_state_batch(struct brw_context *brw, #define brw_state_batch(brw, type, size, alignment, out_offset) \ __brw_state_batch(brw, type, size, alignment, 0, out_offset) +uint32_t brw_state_batch_size(struct brw_context *brw, uint32_t offset); + /* brw_wm_surface_state.c */ void gen4_init_vtable_surface_functions(struct brw_context *brw); uint32_t brw_get_surface_tiling_bits(uint32_t tiling); diff --git a/src/mesa/drivers/dri/i965/brw_state_batch.c b/src/mesa/drivers/dri/i965/brw_state_batch.c index 80c012b108f..0408a2ae437 100644 --- a/src/mesa/drivers/dri/i965/brw_state_batch.c +++ b/src/mesa/drivers/dri/i965/brw_state_batch.c @@ -32,31 +32,16 @@ #include "brw_state.h" #include "intel_batchbuffer.h" #include "main/imports.h" +#include "util/hash_table.h" #include "util/ralloc.h" -static void -brw_track_state_batch(struct brw_context *brw, - enum aub_state_struct_type type, - uint32_t offset, - int size, - int index) +uint32_t +brw_state_batch_size(struct brw_context *brw, uint32_t offset) { - struct intel_batchbuffer *batch = &brw->batch; - - if (!brw->state_batch_list) { - /* Our structs are always aligned to at least 32 bytes, so - * our array doesn't need to be any larger - * TODO: don't use rzalloc - */ - brw->state_batch_list = rzalloc_size(brw, sizeof(*brw->state_batch_list) * - batch->bo->size / 32); - } - - brw->state_batch_list[brw->state_batch_count].offset = offset; - brw->state_batch_list[brw->state_batch_count].size = size; - brw->state_batch_list[brw->state_batch_count].type = type; - brw->state_batch_list[brw->state_batch_count].index = index; - brw->state_batch_count++; + struct hash_entry *entry = + _mesa_hash_table_search(brw->batch.state_batch_sizes, + (void *) (uintptr_t) offset); + return entry ? (uintptr_t) entry->data : 0; } /** @@ -100,8 +85,11 @@ __brw_state_batch(struct brw_context *brw, batch->state_batch_offset = offset; - if (unlikely(INTEL_DEBUG & DEBUG_BATCH)) - brw_track_state_batch(brw, type, offset, size, index); + if (unlikely(INTEL_DEBUG & DEBUG_BATCH)) { + _mesa_hash_table_insert(batch->state_batch_sizes, + (void *) (uintptr_t) offset, + (void *) (uintptr_t) size); + } *out_offset = offset; return batch->map + (offset>>2); diff --git a/src/mesa/drivers/dri/i965/brw_state_dump.c b/src/mesa/drivers/dri/i965/brw_state_dump.c deleted file mode 100644 index bc9b9a352df..00000000000 --- a/src/mesa/drivers/dri/i965/brw_state_dump.c +++ /dev/null @@ -1,827 +0,0 @@ -/* - * Copyright © 2007-2015 Intel Corporation - * - * Permission is hereby granted, free of charge, to any person obtaining a - * copy of this software and associated documentation files (the "Software"), - * to deal in the Software without restriction, including without limitation - * the rights to use, copy, modify, merge, publish, distribute, sublicense, - * and/or sell copies of the Software, and to permit persons to whom the - * Software is furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice (including the next - * paragraph) shall be included in all copies or substantial portions of the - * Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL - * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS - * IN THE SOFTWARE. - * - * Authors: - * Eric Anholt - * - */ - -#include "main/mtypes.h" -#include "intel_batchbuffer.h" - -#include "isl/isl.h" - -#include "brw_context.h" -#include "brw_defines.h" -#include "brw_state.h" - -static const char *sampler_mip_filter[] = { - "NONE", - "NEAREST", - "RSVD", - "LINEAR" -}; - -static const char *sampler_mag_filter[] = { - "NEAREST", - "LINEAR", - "ANISOTROPIC", - "FLEXIBLE (GEN8+)", - "RSVD", "RSVD", - "MONO", - "RSVD" -}; - -static const char *sampler_addr_mode[] = { - "WRAP", - "MIRROR", - "CLAMP", - "CUBE", - "CLAMP_BORDER", - "MIRROR_ONCE", - "HALF_BORDER" -}; - -static const char *surface_tiling[] = { - "LINEAR", - "W-tiled", - "X-tiled", - "Y-tiled" -}; - -static void -batch_out(struct brw_context *brw, const char *name, uint32_t offset, - int index, char *fmt, ...) PRINTFLIKE(5, 6); - -static void -batch_out(struct brw_context *brw, const char *name, uint32_t offset, - int index, char *fmt, ...) -{ - uint32_t *data = brw->batch.bo->virtual + offset; - va_list va; - - fprintf(stderr, "0x%08x: 0x%08x: %8s: ", - offset + index * 4, data[index], name); - va_start(va, fmt); - vfprintf(stderr, fmt, va); - va_end(va); -} - -static void -batch_out64(struct brw_context *brw, const char *name, uint32_t offset, - int index, char *fmt, ...) -{ - uint32_t *tmp = brw->batch.bo->virtual + offset; - - /* Swap the dwords since we want to handle this as a 64b value, but the data - * is typically emitted as dwords. - */ - uint64_t data = ((uint64_t)tmp[index + 1]) << 32 | tmp[index]; - va_list va; - - fprintf(stderr, "0x%08x: 0x%016" PRIx64 ": %8s: ", - offset + index * 4, data, name); - va_start(va, fmt); - vfprintf(stderr, fmt, va); - va_end(va); -} - -static const char * -get_965_surfacetype(unsigned int surfacetype) -{ - switch (surfacetype) { - case 0: return "1D"; - case 1: return "2D"; - case 2: return "3D"; - case 3: return "CUBE"; - case 4: return "BUFFER"; - case 7: return "NULL"; - default: return "unknown"; - } -} - -static void dump_vs_state(struct brw_context *brw, uint32_t offset) -{ - const char *name = "VS_STATE"; - struct brw_vs_unit_state *vs = brw->batch.bo->virtual + offset; - - batch_out(brw, name, offset, 0, "thread0\n"); - batch_out(brw, name, offset, 1, "thread1\n"); - batch_out(brw, name, offset, 2, "thread2\n"); - batch_out(brw, name, offset, 3, "thread3\n"); - batch_out(brw, name, offset, 4, "thread4: %d threads\n", - vs->thread4.max_threads + 1); - batch_out(brw, name, offset, 5, "vs5\n"); - batch_out(brw, name, offset, 6, "vs6\n"); -} - -static void dump_gs_state(struct brw_context *brw, uint32_t offset) -{ - const char *name = "GS_STATE"; - struct brw_gs_unit_state *gs = brw->batch.bo->virtual + offset; - - batch_out(brw, name, offset, 0, "thread0\n"); - batch_out(brw, name, offset, 1, "thread1\n"); - batch_out(brw, name, offset, 2, "thread2\n"); - batch_out(brw, name, offset, 3, "thread3\n"); - batch_out(brw, name, offset, 4, "thread4: %d threads\n", - gs->thread4.max_threads + 1); - batch_out(brw, name, offset, 5, "vs5\n"); - batch_out(brw, name, offset, 6, "vs6\n"); -} - -static void dump_clip_state(struct brw_context *brw, uint32_t offset) -{ - const char *name = "CLIP_STATE"; - struct brw_clip_unit_state *clip = brw->batch.bo->virtual + offset; - - batch_out(brw, name, offset, 0, "thread0\n"); - batch_out(brw, name, offset, 1, "thread1\n"); - batch_out(brw, name, offset, 2, "thread2\n"); - batch_out(brw, name, offset, 3, "thread3\n"); - batch_out(brw, name, offset, 4, "thread4: %d threads\n", - clip->thread4.max_threads + 1); - batch_out(brw, name, offset, 5, "clip5\n"); - batch_out(brw, name, offset, 6, "clip6\n"); - batch_out(brw, name, offset, 7, "vp xmin %f\n", clip->viewport_xmin); - batch_out(brw, name, offset, 8, "vp xmax %f\n", clip->viewport_xmax); - batch_out(brw, name, offset, 9, "vp ymin %f\n", clip->viewport_ymin); - batch_out(brw, name, offset, 10, "vp ymax %f\n", clip->viewport_ymax); -} - -static void dump_sf_state(struct brw_context *brw, uint32_t offset) -{ - const char *name = "SF_STATE"; - struct brw_sf_unit_state *sf = brw->batch.bo->virtual + offset; - - batch_out(brw, name, offset, 0, "thread0\n"); - batch_out(brw, name, offset, 1, "thread1\n"); - batch_out(brw, name, offset, 2, "thread2\n"); - batch_out(brw, name, offset, 3, "thread3\n"); - batch_out(brw, name, offset, 4, "thread4: %d threads\n", - sf->thread4.max_threads + 1); - batch_out(brw, name, offset, 5, "sf5: viewport offset\n"); - batch_out(brw, name, offset, 6, "sf6\n"); - batch_out(brw, name, offset, 7, "sf7\n"); -} - -static void dump_wm_state(struct brw_context *brw, uint32_t offset) -{ - const char *name = "WM_STATE"; - struct brw_wm_unit_state *wm = brw->batch.bo->virtual + offset; - - batch_out(brw, name, offset, 0, "thread0\n"); - batch_out(brw, name, offset, 1, "thread1\n"); - batch_out(brw, name, offset, 2, "thread2\n"); - batch_out(brw, name, offset, 3, "thread3\n"); - batch_out(brw, name, offset, 4, "wm4\n"); - batch_out(brw, name, offset, 5, "wm5: %s%s%s%s%s%s, %d threads\n", - wm->wm5.enable_8_pix ? "8pix" : "", - wm->wm5.enable_16_pix ? "16pix" : "", - wm->wm5.program_uses_depth ? ", uses depth" : "", - wm->wm5.program_computes_depth ? ", computes depth" : "", - wm->wm5.program_uses_killpixel ? ", kills" : "", - wm->wm5.thread_dispatch_enable ? "" : ", no dispatch", - wm->wm5.max_threads + 1); - batch_out(brw, name, offset, 6, "depth offset constant %f\n", - wm->global_depth_offset_constant); - batch_out(brw, name, offset, 7, "depth offset scale %f\n", - wm->global_depth_offset_scale); - batch_out(brw, name, offset, 8, "wm8: kernel 1 (gen5+)\n"); - batch_out(brw, name, offset, 9, "wm9: kernel 2 (gen5+)\n"); - batch_out(brw, name, offset, 10, "wm10: kernel 3 (gen5+)\n"); -} - -static void dump_surface_state(struct brw_context *brw, uint32_t offset) -{ - const char *name = "SURF"; - uint32_t *surf = brw->batch.bo->virtual + offset; - - batch_out(brw, name, offset, 0, "%s %s\n", - get_965_surfacetype(GET_FIELD(surf[0], BRW_SURFACE_TYPE)), - isl_format_get_name(GET_FIELD(surf[0], BRW_SURFACE_FORMAT))); - batch_out(brw, name, offset, 1, "offset\n"); - batch_out(brw, name, offset, 2, "%dx%d size, %d mips\n", - GET_FIELD(surf[2], BRW_SURFACE_WIDTH) + 1, - GET_FIELD(surf[2], BRW_SURFACE_HEIGHT) + 1, - GET_FIELD(surf[2], BRW_SURFACE_LOD)); - batch_out(brw, name, offset, 3, "pitch %d, %s tiled\n", - GET_FIELD(surf[3], BRW_SURFACE_PITCH) + 1, - (surf[3] & BRW_SURFACE_TILED) ? - ((surf[3] & BRW_SURFACE_TILED_Y) ? "Y" : "X") : "not"); - batch_out(brw, name, offset, 4, "mip base %d\n", - GET_FIELD(surf[4], BRW_SURFACE_MIN_LOD)); - batch_out(brw, name, offset, 5, "x,y offset: %d,%d\n", - GET_FIELD(surf[5], BRW_SURFACE_X_OFFSET), - GET_FIELD(surf[5], BRW_SURFACE_Y_OFFSET)); -} - -static void dump_gen7_surface_state(struct brw_context *brw, uint32_t offset) -{ - const char *name = "SURF"; - uint32_t *surf = brw->batch.bo->virtual + offset; - - batch_out(brw, name, offset, 0, "%s %s %s\n", - get_965_surfacetype(GET_FIELD(surf[0], BRW_SURFACE_TYPE)), - isl_format_get_name(GET_FIELD(surf[0], BRW_SURFACE_FORMAT)), - (surf[0] & GEN7_SURFACE_IS_ARRAY) ? "array" : ""); - batch_out(brw, name, offset, 1, "offset\n"); - batch_out(brw, name, offset, 2, "%dx%d size, %d mips, %d slices\n", - GET_FIELD(surf[2], GEN7_SURFACE_WIDTH) + 1, - GET_FIELD(surf[2], GEN7_SURFACE_HEIGHT) + 1, - surf[5] & INTEL_MASK(3, 0), - GET_FIELD(surf[3], BRW_SURFACE_DEPTH) + 1); - batch_out(brw, name, offset, 3, "pitch %d, %stiled\n", - (surf[3] & INTEL_MASK(17, 0)) + 1, - (surf[0] & (1 << 14)) ? "" : "not "); - batch_out(brw, name, offset, 4, "min array element %d, array extent %d\n", - GET_FIELD(surf[4], GEN7_SURFACE_MIN_ARRAY_ELEMENT), - GET_FIELD(surf[4], GEN7_SURFACE_RENDER_TARGET_VIEW_EXTENT) + 1); - batch_out(brw, name, offset, 5, "mip base %d\n", - GET_FIELD(surf[5], GEN7_SURFACE_MIN_LOD)); - batch_out(brw, name, offset, 6, "x,y offset: %d,%d\n", - GET_FIELD(surf[5], BRW_SURFACE_X_OFFSET), - GET_FIELD(surf[5], BRW_SURFACE_Y_OFFSET)); - batch_out(brw, name, offset, 7, "\n"); -} - -static float q_to_float(uint32_t data, int integer_end, int integer_start, - int fractional_end, int fractional_start) -{ - /* Convert the number to floating point. */ - float n = GET_BITS(data, integer_start, fractional_end); - - /* Multiply by 2^-n */ - return n * exp2(-(fractional_end - fractional_start + 1)); -} - -static void -dump_gen8_surface_state(struct brw_context *brw, uint32_t offset, int index) -{ - uint32_t *surf = brw->batch.bo->virtual + offset; - int aux_mode = surf[6] & INTEL_MASK(2, 0); - const char *aux_str; - char *name; - - if (brw->gen >= 9 && (aux_mode == 1 || aux_mode == 5)) { - bool msrt = GET_BITS(surf[4], 5, 3) > 0; - bool compression = GET_FIELD(surf[7], GEN9_SURFACE_RT_COMPRESSION) == 1; - aux_str = ralloc_asprintf(NULL, "AUX_CCS_%c (%s, MULTISAMPLE_COUNT%c1)", - (aux_mode == 1) ? 'D' : 'E', - compression ? "Compressed RT" : "Uncompressed", - msrt ? '>' : '='); - } else { - static const char *surface_aux_mode[] = { "AUX_NONE", "AUX_MCS", - "AUX_APPEND", "AUX_HIZ", - "RSVD", "RSVD"}; - aux_str = ralloc_asprintf(NULL, "%s", surface_aux_mode[aux_mode]); - } - - name = ralloc_asprintf(NULL, "SURF%03d", index); - batch_out(brw, name, offset, 0, "%s %s %s VALIGN%d HALIGN%d %s\n", - get_965_surfacetype(GET_FIELD(surf[0], BRW_SURFACE_TYPE)), - isl_format_get_name(GET_FIELD(surf[0], BRW_SURFACE_FORMAT)), - (surf[0] & GEN7_SURFACE_IS_ARRAY) ? "array" : "", - 1 << (GET_BITS(surf[0], 17, 16) + 1), /* VALIGN */ - 1 << (GET_BITS(surf[0], 15, 14) + 1), /* HALIGN */ - surface_tiling[GET_BITS(surf[0], 13, 12)]); - batch_out(brw, name, offset, 1, "MOCS: 0x%x Base MIP: %.1f (%u mips) Surface QPitch: %d\n", - GET_FIELD(surf[1], GEN8_SURFACE_MOCS), - q_to_float(surf[1], 23, 20, 19, 19), - surf[5] & INTEL_MASK(3, 0), - GET_FIELD(surf[1], GEN8_SURFACE_QPITCH) << 2); - batch_out(brw, name, offset, 2, "%dx%d [%s]\n", - GET_FIELD(surf[2], GEN7_SURFACE_WIDTH) + 1, - GET_FIELD(surf[2], GEN7_SURFACE_HEIGHT) + 1, - aux_str); - batch_out(brw, name, offset, 3, "%d slices (depth), pitch: %d\n", - GET_FIELD(surf[3], BRW_SURFACE_DEPTH) + 1, - (surf[3] & INTEL_MASK(17, 0)) + 1); - batch_out(brw, name, offset, 4, "min array element: %d, array extent %d, MULTISAMPLE_%d\n", - GET_FIELD(surf[4], GEN7_SURFACE_MIN_ARRAY_ELEMENT), - GET_FIELD(surf[4], GEN7_SURFACE_RENDER_TARGET_VIEW_EXTENT) + 1, - 1 << GET_BITS(surf[4], 5, 3)); - batch_out(brw, name, offset, 5, "x,y offset: %d,%d, min LOD: %d," - " tr_mode (gen9+): %d, mip tail (gen9+): %d\n", - GET_FIELD(surf[5], BRW_SURFACE_X_OFFSET), - GET_FIELD(surf[5], BRW_SURFACE_Y_OFFSET), - GET_FIELD(surf[5], GEN7_SURFACE_MIN_LOD), - GET_FIELD(surf[5], GEN9_SURFACE_TRMODE), - GET_FIELD(surf[5], GEN9_SURFACE_MIP_TAIL_START_LOD)); - batch_out(brw, name, offset, 6, "AUX pitch: %d qpitch: %d\n", - GET_FIELD(surf[6], GEN8_SURFACE_AUX_QPITCH) << 2, - GET_FIELD(surf[6], GEN8_SURFACE_AUX_PITCH) << 2); - if (brw->gen >= 9) { - batch_out(brw, name, offset, 7, "Clear color: R(%x)G(%x)B(%x)A(%x)\n", - surf[12], surf[13], surf[14], surf[15]); - } else { - batch_out(brw, name, offset, 7, "Clear color: %c%c%c%c\n", - GET_BITS(surf[7], 31, 31) ? 'R' : '-', - GET_BITS(surf[7], 30, 30) ? 'G' : '-', - GET_BITS(surf[7], 29, 29) ? 'B' : '-', - GET_BITS(surf[7], 28, 28) ? 'A' : '-'); - } - - for (int i = 8; i < 12; i++) - batch_out(brw, name, offset, i, "0x%08x\n", surf[i]); - - ralloc_free((void *)aux_str); - ralloc_free(name); -} - -static void -dump_sdc(struct brw_context *brw, uint32_t offset) -{ - const char *name = "SDC"; - - if (brw->gen >= 5 && brw->gen <= 6) { - struct gen5_sampler_default_color *sdc = (brw->batch.bo->virtual + - offset); - batch_out(brw, name, offset, 0, "unorm rgba\n"); - batch_out(brw, name, offset, 1, "r %f\n", sdc->f[0]); - batch_out(brw, name, offset, 2, "b %f\n", sdc->f[1]); - batch_out(brw, name, offset, 3, "g %f\n", sdc->f[2]); - batch_out(brw, name, offset, 4, "a %f\n", sdc->f[3]); - batch_out(brw, name, offset, 5, "half float rg\n"); - batch_out(brw, name, offset, 6, "half float ba\n"); - batch_out(brw, name, offset, 7, "u16 rg\n"); - batch_out(brw, name, offset, 8, "u16 ba\n"); - batch_out(brw, name, offset, 9, "s16 rg\n"); - batch_out(brw, name, offset, 10, "s16 ba\n"); - batch_out(brw, name, offset, 11, "s8 rgba\n"); - } else { - float *sdc = brw->batch.bo->virtual + offset; - batch_out(brw, name, offset, 0, "r %f\n", sdc[0]); - batch_out(brw, name, offset, 1, "g %f\n", sdc[1]); - batch_out(brw, name, offset, 2, "b %f\n", sdc[2]); - batch_out(brw, name, offset, 3, "a %f\n", sdc[3]); - } -} - -static void dump_sampler_state(struct brw_context *brw, - uint32_t offset, uint32_t size) -{ - unsigned i; - uint32_t *samp = brw->batch.bo->virtual + offset; - - for (i = 0; i < size / 16; i++) { - char name[20]; - - sprintf(name, "WM SAMP%u", i); - batch_out(brw, name, offset, 0, "filtering\n"); - batch_out(brw, name, offset, 1, "wrapping, lod\n"); - batch_out(brw, name, offset, 2, "default color pointer\n"); - batch_out(brw, name, offset, 3, "chroma key, aniso\n"); - - samp += 4; - offset += 4 * sizeof(uint32_t); - } -} - -static void gen7_dump_sampler_state(struct brw_context *brw, - uint32_t offset, uint32_t size) -{ - const uint32_t *samp = brw->batch.bo->virtual + offset; - char name[20]; - - for (int i = 0; i < size / 16; i++) { - sprintf(name, "SAMPLER_STATE %d", i); - batch_out(brw, name, offset, i, - "Disabled = %s, Base Mip: %u.%u, Mip/Mag/Min Filter: %s/%s/%s, LOD Bias: %d.%d\n", - GET_BITS(samp[0], 31, 31) ? "yes" : "no", - GET_BITS(samp[0], 26, 23), - GET_BITS(samp[0], 22, 22), - sampler_mip_filter[GET_FIELD(samp[0], BRW_SAMPLER_MIP_FILTER)], - sampler_mag_filter[GET_FIELD(samp[0], BRW_SAMPLER_MAG_FILTER)], - /* min filter defs are the same as mag */ - sampler_mag_filter[GET_FIELD(samp[0], BRW_SAMPLER_MIN_FILTER)], - GET_BITS(samp[0], 13, 10), - GET_BITS(samp[0], 9, 1) - ); - batch_out(brw, name, offset, i+1, "Min LOD: %u.%u, Max LOD: %u.%u\n", - GET_BITS(samp[1], 31, 28), - GET_BITS(samp[1], 27, 20), - GET_BITS(samp[1], 19, 16), - GET_BITS(samp[1], 15, 8) - ); - batch_out(brw, name, offset, i+2, "Border Color\n"); /* FINISHME: gen8+ */ - batch_out(brw, name, offset, i+3, "Max aniso: RATIO %d:1, TC[XYZ] Address Control: %s|%s|%s, %snormalized coords\n", - (GET_FIELD(samp[3], BRW_SAMPLER_MAX_ANISOTROPY) + 1) * 2, - sampler_addr_mode[GET_FIELD(samp[3], BRW_SAMPLER_TCX_WRAP_MODE)], - sampler_addr_mode[GET_FIELD(samp[3], BRW_SAMPLER_TCY_WRAP_MODE)], - sampler_addr_mode[GET_FIELD(samp[3], BRW_SAMPLER_TCZ_WRAP_MODE)], - (samp[3] & GEN7_SAMPLER_NON_NORMALIZED_COORDINATES) ? "non-" : "" - ); - - samp += 4; - offset += 4 * sizeof(uint32_t); - } -} - -static void dump_sf_viewport_state(struct brw_context *brw, - uint32_t offset) -{ - const char *name = "SF VP"; - struct brw_sf_viewport *vp = brw->batch.bo->virtual + offset; - - assert(brw->gen < 7); - - batch_out(brw, name, offset, 0, "m00 = %f\n", vp->viewport.m00); - batch_out(brw, name, offset, 1, "m11 = %f\n", vp->viewport.m11); - batch_out(brw, name, offset, 2, "m22 = %f\n", vp->viewport.m22); - batch_out(brw, name, offset, 3, "m30 = %f\n", vp->viewport.m30); - batch_out(brw, name, offset, 4, "m31 = %f\n", vp->viewport.m31); - batch_out(brw, name, offset, 5, "m32 = %f\n", vp->viewport.m32); - - batch_out(brw, name, offset, 6, "top left = %d,%d\n", - vp->scissor.xmin, vp->scissor.ymin); - batch_out(brw, name, offset, 7, "bottom right = %d,%d\n", - vp->scissor.xmax, vp->scissor.ymax); -} - -static void dump_clip_viewport_state(struct brw_context *brw, - uint32_t offset) -{ - const char *name = "CLIP VP"; - struct brw_clipper_viewport *vp = brw->batch.bo->virtual + offset; - - assert(brw->gen < 7); - - batch_out(brw, name, offset, 0, "xmin = %f\n", vp->xmin); - batch_out(brw, name, offset, 1, "xmax = %f\n", vp->xmax); - batch_out(brw, name, offset, 2, "ymin = %f\n", vp->ymin); - batch_out(brw, name, offset, 3, "ymax = %f\n", vp->ymax); -} - -static void dump_sf_clip_viewport_state(struct brw_context *brw, - uint32_t offset) -{ - const char *name = "SF_CLIP VP"; - struct gen7_sf_clip_viewport *vp = brw->batch.bo->virtual + offset; - - assert(brw->gen >= 7); - - batch_out(brw, name, offset, 0, "m00 = %f\n", vp->viewport.m00); - batch_out(brw, name, offset, 1, "m11 = %f\n", vp->viewport.m11); - batch_out(brw, name, offset, 2, "m22 = %f\n", vp->viewport.m22); - batch_out(brw, name, offset, 3, "m30 = %f\n", vp->viewport.m30); - batch_out(brw, name, offset, 4, "m31 = %f\n", vp->viewport.m31); - batch_out(brw, name, offset, 5, "m32 = %f\n", vp->viewport.m32); - batch_out(brw, name, offset, 8, "guardband xmin = %f\n", vp->guardband.xmin); - batch_out(brw, name, offset, 9, "guardband xmax = %f\n", vp->guardband.xmax); - batch_out(brw, name, offset, 9, "guardband ymin = %f\n", vp->guardband.ymin); - batch_out(brw, name, offset, 10, "guardband ymax = %f\n", vp->guardband.ymax); - if (brw->gen >= 8) { - float *cc_vp = brw->batch.bo->virtual + offset; - batch_out(brw, name, offset, 12, "Min extents: %.2fx%.2f\n", - cc_vp[12], cc_vp[14]); - batch_out(brw, name, offset, 14, "Max extents: %.2fx%.2f\n", - cc_vp[13], cc_vp[15]); - } -} - - -static void dump_cc_viewport_state(struct brw_context *brw, uint32_t offset) -{ - const char *name = "CC VP"; - struct brw_cc_viewport *vp = brw->batch.bo->virtual + offset; - - batch_out(brw, name, offset, 0, "min_depth = %f\n", vp->min_depth); - batch_out(brw, name, offset, 1, "max_depth = %f\n", vp->max_depth); -} - -static void dump_depth_stencil_state(struct brw_context *brw, uint32_t offset) -{ - const char *name = "D_S"; - struct gen6_depth_stencil_state *ds = brw->batch.bo->virtual + offset; - - batch_out(brw, name, offset, 0, - "stencil %sable, func %d, write %sable\n", - ds->ds0.stencil_enable ? "en" : "dis", - ds->ds0.stencil_func, - ds->ds0.stencil_write_enable ? "en" : "dis"); - batch_out(brw, name, offset, 1, - "stencil test mask 0x%x, write mask 0x%x\n", - ds->ds1.stencil_test_mask, ds->ds1.stencil_write_mask); - batch_out(brw, name, offset, 2, - "depth test %sable, func %d, write %sable\n", - ds->ds2.depth_test_enable ? "en" : "dis", - ds->ds2.depth_test_func, - ds->ds2.depth_write_enable ? "en" : "dis"); -} - -static void dump_cc_state_gen4(struct brw_context *brw, uint32_t offset) -{ - const char *name = "CC"; - - batch_out(brw, name, offset, 0, "cc0\n"); - batch_out(brw, name, offset, 1, "cc1\n"); - batch_out(brw, name, offset, 2, "cc2\n"); - batch_out(brw, name, offset, 3, "cc3\n"); - batch_out(brw, name, offset, 4, "cc4: viewport offset\n"); - batch_out(brw, name, offset, 5, "cc5\n"); - batch_out(brw, name, offset, 6, "cc6\n"); - batch_out(brw, name, offset, 7, "cc7\n"); -} - -static void dump_cc_state_gen6(struct brw_context *brw, uint32_t offset) -{ - const char *name = "CC"; - struct gen6_color_calc_state *cc = brw->batch.bo->virtual + offset; - - batch_out(brw, name, offset, 0, - "alpha test format %s, round disable %d, stencil ref %d, " - "bf stencil ref %d\n", - cc->cc0.alpha_test_format ? "FLOAT32" : "UNORM8", - cc->cc0.round_disable, - cc->cc0.stencil_ref, - cc->cc0.bf_stencil_ref); - batch_out(brw, name, offset, 1, "\n"); - batch_out(brw, name, offset, 2, "constant red %f\n", cc->constant_r); - batch_out(brw, name, offset, 3, "constant green %f\n", cc->constant_g); - batch_out(brw, name, offset, 4, "constant blue %f\n", cc->constant_b); - batch_out(brw, name, offset, 5, "constant alpha %f\n", cc->constant_a); -} - -static void dump_blend_state(struct brw_context *brw, uint32_t offset) -{ - const char *name = "BLEND"; - - batch_out(brw, name, offset, 0, "\n"); - batch_out(brw, name, offset, 1, "\n"); -} - -static void -gen8_dump_blend_state(struct brw_context *brw, uint32_t offset, uint32_t size) -{ - const uint32_t *blend = brw->batch.bo->virtual + offset; - const char *logicop[] = - { - "LOGICOP_CLEAR (BLACK)", - "LOGICOP_NOR", - "LOGICOP_AND_INVERTED", - "LOGICOP_COPY_INVERTED", - "LOGICOP_AND_REVERSE", - "LOGICOP_INVERT", - "LOGICOP_XOR", - "LOGICOP_NAND", - "LOGICOP_AND", - "LOGICOP_EQUIV", - "LOGICOP_NOOP", - "LOGICOP_OR_INVERTED", - "LOGICOP_COPY", - "LOGICOP_OR_REVERSE", - "LOGICOP_OR", - "LOGICOP_SET (WHITE)" - }; - - const char *blend_function[] = - { "ADD", "SUBTRACT", "REVERSE_SUBTRACT", "MIN", "MAX};" }; - - const char *blend_factor[0x1b] = - { - "RSVD", - "ONE", - "SRC_COLOR", "SRC_ALPHA", - "DST_ALPHA", "DST_COLOR", - "SRC_ALPHA_SATURATE", - "CONST_COLOR", "CONST_ALPHA", - "SRC1_COLOR", "SRC1_ALPHA", - "RSVD", "RSVD", "RSVD", "RSVD", "RSVD", "RSVD", - "ZERO", - "INV_SRC_COLOR", "INV_SRC_ALPHA", - "INV_DST_ALPHA", "INV_DST_COLOR", - "RSVD", - "INV_CONST_COLOR", "INV_CONST_ALPHA", - "INV_SRC1_COLOR", "INV_SRC1_ALPHA" - }; - - batch_out(brw, "BLEND", offset, 0, "Alpha blend/test\n"); - - if (((size) % 2) != 0) - fprintf(stderr, "Invalid blend state size %d\n", size); - - for (int i = 1; i < size / 4; i += 2) { - char name[sizeof("BLEND_ENTRYXXX")]; - sprintf(name, "BLEND_ENTRY%02d", (i - 1) / 2); - if (blend[i + 1] & GEN8_BLEND_LOGIC_OP_ENABLE) { - batch_out(brw, name, offset, i + 1, "%s\n", - logicop[GET_FIELD(blend[i + 1], - GEN8_BLEND_LOGIC_OP_FUNCTION)]); - } else if (blend[i] & GEN8_BLEND_COLOR_BUFFER_BLEND_ENABLE) { - batch_out64(brw, name, offset, i, - "\n\t\t\tColor Buffer Blend factor %s,%s,%s,%s (src,dst,src alpha, dst alpha)" - "\n\t\t\tfunction %s,%s (color, alpha), Disables: %c%c%c%c\n", - blend_factor[GET_FIELD(blend[i], - GEN8_BLEND_SRC_BLEND_FACTOR)], - blend_factor[GET_FIELD(blend[i], - GEN8_BLEND_DST_BLEND_FACTOR)], - blend_factor[GET_FIELD(blend[i], - GEN8_BLEND_SRC_ALPHA_BLEND_FACTOR)], - blend_factor[GET_FIELD(blend[i], - GEN8_BLEND_DST_ALPHA_BLEND_FACTOR)], - blend_function[GET_FIELD(blend[i], - GEN8_BLEND_COLOR_BLEND_FUNCTION)], - blend_function[GET_FIELD(blend[i], - GEN8_BLEND_ALPHA_BLEND_FUNCTION)], - blend[i] & GEN8_BLEND_WRITE_DISABLE_RED ? 'R' : '-', - blend[i] & GEN8_BLEND_WRITE_DISABLE_GREEN ? 'G' : '-', - blend[i] & GEN8_BLEND_WRITE_DISABLE_BLUE ? 'B' : '-', - blend[i] & GEN8_BLEND_WRITE_DISABLE_ALPHA ? 'A' : '-' - ); - } else if (!blend[i] && (blend[i + 1] == 0xb)) { - batch_out64(brw, name, offset, i, "NOP blend state\n"); - } else { - batch_out64(brw, name, offset, i, "????\n"); - } - } -} - -static void -dump_scissor(struct brw_context *brw, uint32_t offset) -{ - const char *name = "SCISSOR"; - struct gen6_scissor_rect *scissor = brw->batch.bo->virtual + offset; - - batch_out(brw, name, offset, 0, "xmin %d, ymin %d\n", - scissor->xmin, scissor->ymin); - batch_out(brw, name, offset, 1, "xmax %d, ymax %d\n", - scissor->xmax, scissor->ymax); -} - -static void -dump_vs_constants(struct brw_context *brw, uint32_t offset, uint32_t size) -{ - const char *name = "VS_CONST"; - uint32_t *as_uint = brw->batch.bo->virtual + offset; - float *as_float = brw->batch.bo->virtual + offset; - int i; - - for (i = 0; i < size / 4; i += 4) { - batch_out(brw, name, offset, i, "%3d: (% f % f % f % f) (0x%08x 0x%08x 0x%08x 0x%08x)\n", - i / 4, - as_float[i], as_float[i + 1], as_float[i + 2], as_float[i + 3], - as_uint[i], as_uint[i + 1], as_uint[i + 2], as_uint[i + 3]); - } -} - -static void -dump_wm_constants(struct brw_context *brw, uint32_t offset, uint32_t size) -{ - const char *name = "WM_CONST"; - uint32_t *as_uint = brw->batch.bo->virtual + offset; - float *as_float = brw->batch.bo->virtual + offset; - int i; - - for (i = 0; i < size / 4; i += 4) { - batch_out(brw, name, offset, i, "%3d: (% f % f % f % f) (0x%08x 0x%08x 0x%08x 0x%08x)\n", - i / 4, - as_float[i], as_float[i + 1], as_float[i + 2], as_float[i + 3], - as_uint[i], as_uint[i + 1], as_uint[i + 2], as_uint[i + 3]); - } -} - -static void dump_binding_table(struct brw_context *brw, uint32_t offset, - uint32_t size) -{ - char name[20]; - int i; - uint32_t *data = brw->batch.bo->virtual + offset; - - for (i = 0; i < size / 4; i++) { - if (data[i] == 0) - continue; - - sprintf(name, "BIND%d", i); - batch_out(brw, name, offset, i, "surface state address\n"); - } -} - -static void -dump_state_batch(struct brw_context *brw) -{ - int i; - - for (i = 0; i < brw->state_batch_count; i++) { - uint32_t offset = brw->state_batch_list[i].offset; - uint32_t size = brw->state_batch_list[i].size; - - switch (brw->state_batch_list[i].type) { - case AUB_TRACE_VS_STATE: - dump_vs_state(brw, offset); - break; - case AUB_TRACE_GS_STATE: - dump_gs_state(brw, offset); - break; - case AUB_TRACE_CLIP_STATE: - dump_clip_state(brw, offset); - break; - case AUB_TRACE_SF_STATE: - dump_sf_state(brw, offset); - break; - case AUB_TRACE_WM_STATE: - dump_wm_state(brw, offset); - break; - case AUB_TRACE_CLIP_VP_STATE: - dump_clip_viewport_state(brw, offset); - break; - case AUB_TRACE_SF_VP_STATE: - if (brw->gen >= 7) { - dump_sf_clip_viewport_state(brw, offset); - } else { - dump_sf_viewport_state(brw, offset); - } - break; - case AUB_TRACE_CC_VP_STATE: - dump_cc_viewport_state(brw, offset); - break; - case AUB_TRACE_DEPTH_STENCIL_STATE: - dump_depth_stencil_state(brw, offset); - break; - case AUB_TRACE_CC_STATE: - if (brw->gen >= 6) - dump_cc_state_gen6(brw, offset); - else - dump_cc_state_gen4(brw, offset); - break; - case AUB_TRACE_BLEND_STATE: - if (brw->gen >= 8) - gen8_dump_blend_state(brw, offset, size); - else - dump_blend_state(brw, offset); - break; - case AUB_TRACE_BINDING_TABLE: - dump_binding_table(brw, offset, size); - break; - case AUB_TRACE_SURFACE_STATE: - if (brw->gen >= 8) { - dump_gen8_surface_state(brw, offset, - brw->state_batch_list[i].index); - } else if (brw->gen >= 7) { - dump_gen7_surface_state(brw, offset); - } else { - dump_surface_state(brw, offset); - } - break; - case AUB_TRACE_SAMPLER_STATE: - if (brw->gen >= 7) - gen7_dump_sampler_state(brw, offset, size); - else - dump_sampler_state(brw, offset, size); - break; - case AUB_TRACE_SAMPLER_DEFAULT_COLOR: - dump_sdc(brw, offset); - break; - case AUB_TRACE_SCISSOR_STATE: - dump_scissor(brw, offset); - break; - case AUB_TRACE_VS_CONSTANTS: - dump_vs_constants(brw, offset, size); - break; - case AUB_TRACE_WM_CONSTANTS: - dump_wm_constants(brw, offset, size); - break; - default: - break; - } - } -} - -/** - * Print additional debug information associated with the batchbuffer - * when DEBUG_BATCH is set. - * - * For 965, this means mapping the state buffers that would have been referenced - * by the batchbuffer and dumping them. - * - * The buffer offsets printed rely on the buffer containing the last offset - * it was validated at. - */ -void brw_debug_batch(struct brw_context *brw) -{ - drm_intel_bo_map(brw->batch.bo, false); - dump_state_batch(brw); - drm_intel_bo_unmap(brw->batch.bo); - - if (0) - brw_print_program_cache(brw); -} diff --git a/src/mesa/drivers/dri/i965/intel_batchbuffer.c b/src/mesa/drivers/dri/i965/intel_batchbuffer.c index 522114ec23c..49a00c12ba2 100644 --- a/src/mesa/drivers/dri/i965/intel_batchbuffer.c +++ b/src/mesa/drivers/dri/i965/intel_batchbuffer.c @@ -33,6 +33,8 @@ #include "brw_state.h" #include "common/gen_decoder.h" +#include "util/hash_table.h" + #include #include @@ -40,6 +42,18 @@ static void intel_batchbuffer_reset(struct intel_batchbuffer *batch, dri_bufmgr *bufmgr, bool has_llc); +static bool +uint_key_compare(const void *a, const void *b) +{ + return a == b; +} + +static uint32_t +uint_key_hash(const void *key) +{ + return (uintptr_t) key; +} + void intel_batchbuffer_init(struct intel_batchbuffer *batch, dri_bufmgr *bufmgr, bool has_llc) @@ -51,6 +65,11 @@ intel_batchbuffer_init(struct intel_batchbuffer *batch, dri_bufmgr *bufmgr, batch->map = batch->cpu_map; batch->map_next = batch->cpu_map; } + + if (INTEL_DEBUG & DEBUG_BATCH) { + batch->state_batch_sizes = + _mesa_hash_table_create(NULL, uint_key_hash, uint_key_compare); + } } static void @@ -79,6 +98,9 @@ intel_batchbuffer_reset(struct intel_batchbuffer *batch, dri_bufmgr *bufmgr, * first BEGIN_BATCH or BEGIN_BATCH_BLT. Mark it as unknown. */ batch->ring = UNKNOWN_RING; + + if (batch->state_batch_sizes) + _mesa_hash_table_clear(batch->state_batch_sizes, NULL); } static void @@ -112,6 +134,8 @@ intel_batchbuffer_free(struct intel_batchbuffer *batch) free(batch->cpu_map); drm_intel_bo_unreference(batch->last_bo); drm_intel_bo_unreference(batch->bo); + if (batch->state_batch_sizes) + _mesa_hash_table_destroy(batch->state_batch_sizes, NULL); } void @@ -141,6 +165,39 @@ intel_batchbuffer_require_space(struct brw_context *brw, GLuint sz, #define BLUE_HEADER CSI "0;44m" #define NORMAL CSI "0m" + +static void +decode_struct(struct brw_context *brw, struct gen_spec *spec, + const char *struct_name, uint32_t *data, + uint32_t gtt_offset, uint32_t offset, bool color) +{ + struct gen_group *group = gen_spec_find_struct(spec, struct_name); + if (!group) + return; + + fprintf(stderr, "%s\n", struct_name); + gen_print_group(stderr, group, gtt_offset + offset, + &data[offset / 4], 0, color); +} + +static void +decode_structs(struct brw_context *brw, struct gen_spec *spec, + const char *struct_name, + uint32_t *data, uint32_t gtt_offset, uint32_t offset, + int struct_size, bool color) +{ + struct gen_group *group = gen_spec_find_struct(spec, struct_name); + if (!group) + return; + + int entries = brw_state_batch_size(brw, offset) / struct_size; + for (int i = 0; i < entries; i++) { + fprintf(stderr, "%s %d\n", struct_name, i); + gen_print_group(stderr, group, gtt_offset + offset, + &data[(offset + i * struct_size) / 4], 0, color); + } +} + static void do_batch_dump(struct brw_context *brw) { @@ -180,14 +237,89 @@ do_batch_dump(struct brw_context *brw) offset, p[0], gen_group_get_name(inst), reset_color); gen_print_group(stderr, inst, offset, p, 1, color); + + switch (gen_group_get_opcode(inst) >> 16) { + case _3DSTATE_PIPELINED_POINTERS: + /* TODO: Decode Gen4-5 pipelined pointers */ + break; + case _3DSTATE_BINDING_TABLE_POINTERS_VS: + case _3DSTATE_BINDING_TABLE_POINTERS_HS: + case _3DSTATE_BINDING_TABLE_POINTERS_DS: + case _3DSTATE_BINDING_TABLE_POINTERS_GS: + case _3DSTATE_BINDING_TABLE_POINTERS_PS: { + struct gen_group *group = + gen_spec_find_struct(spec, "RENDER_SURFACE_STATE"); + if (!group) + break; + + uint32_t bt_offset = p[1] & ~0x1fu; + int bt_entries = brw_state_batch_size(brw, bt_offset) / 4; + uint32_t *bt_pointers = &data[bt_offset / 4]; + for (int i = 0; i < bt_entries; i++) { + fprintf(stderr, "SURFACE_STATE - BTI = %d\n", i); + gen_print_group(stderr, group, gtt_offset + bt_pointers[i], + &data[bt_pointers[i] / 4], 0, color); + } + break; + } + case _3DSTATE_SAMPLER_STATE_POINTERS_VS: + case _3DSTATE_SAMPLER_STATE_POINTERS_HS: + case _3DSTATE_SAMPLER_STATE_POINTERS_DS: + case _3DSTATE_SAMPLER_STATE_POINTERS_GS: + case _3DSTATE_SAMPLER_STATE_POINTERS_PS: + decode_structs(brw, spec, "SAMPLER_STATE", data, + gtt_offset, p[1] & ~0x1fu, 4 * 4, color); + break; + case _3DSTATE_VIEWPORT_STATE_POINTERS: + decode_structs(brw, spec, "CLIP_VIEWPORT", data, + gtt_offset, p[1] & ~0x3fu, 4 * 4, color); + decode_structs(brw, spec, "SF_VIEWPORT", data, + gtt_offset, p[1] & ~0x3fu, 8 * 4, color); + decode_structs(brw, spec, "CC_VIEWPORT", data, + gtt_offset, p[3] & ~0x3fu, 2 * 4, color); + break; + case _3DSTATE_VIEWPORT_STATE_POINTERS_CC: + decode_structs(brw, spec, "CC_VIEWPORT", data, + gtt_offset, p[1] & ~0x3fu, 2 * 4, color); + break; + case _3DSTATE_VIEWPORT_STATE_POINTERS_SF_CL: + decode_structs(brw, spec, "SF_CLIP_VIEWPORT", data, + gtt_offset, p[1] & ~0x3fu, 16 * 4, color); + break; + case _3DSTATE_SCISSOR_STATE_POINTERS: + decode_structs(brw, spec, "SCISSOR_RECT", data, + gtt_offset, p[1] & ~0x1fu, 2 * 4, color); + break; + case _3DSTATE_BLEND_STATE_POINTERS: + /* TODO: handle Gen8+ extra dword at the beginning */ + decode_structs(brw, spec, "BLEND_STATE", data, + gtt_offset, p[1] & ~0x3fu, 8 * 4, color); + break; + case _3DSTATE_CC_STATE_POINTERS: + if (brw->gen >= 7) { + decode_struct(brw, spec, "COLOR_CALC_STATE", data, + gtt_offset, p[1] & ~0x3fu, color); + } else if (brw->gen == 6) { + decode_structs(brw, spec, "BLEND_STATE", data, + gtt_offset, p[1] & ~0x3fu, 2 * 4, color); + decode_struct(brw, spec, "DEPTH_STENCIL_STATE", data, + gtt_offset, p[2] & ~0x3fu, color); + decode_struct(brw, spec, "COLOR_CALC_STATE", data, + gtt_offset, p[3] & ~0x3fu, color); + } + break; + case _3DSTATE_DEPTH_STENCIL_STATE_POINTERS: + decode_struct(brw, spec, "DEPTH_STENCIL_STATE", data, + gtt_offset, p[1] & ~0x3fu, color); + break; + } + length = gen_group_get_length(inst, p); } if (ret == 0) { drm_intel_bo_unmap(batch->bo); } - - brw_debug_batch(brw); } #else static void do_batch_dump(struct brw_context *brw) { } @@ -214,8 +346,6 @@ brw_new_batch(struct brw_context *brw) brw->ctx.NewDriverState |= BRW_NEW_BATCH; - brw->state_batch_count = 0; - brw->ib.type = -1; /* We need to periodically reap the shader time results, because rollover