From: Brian Paul <brian.paul@tungstengraphics.com>
Date: Mon, 21 Jul 2008 20:16:07 +0000 (-0600)
Subject: mesa: fix some issues in _mesa_validate_program()
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=70d3928f6366c94b147d768d55eaa7d1f45462bd;p=mesa.git

mesa: fix some issues in _mesa_validate_program()
---

diff --git a/src/mesa/shader/shader_api.c b/src/mesa/shader/shader_api.c
index e25cb632166..f390e3cef45 100644
--- a/src/mesa/shader/shader_api.c
+++ b/src/mesa/shader/shader_api.c
@@ -1534,15 +1534,19 @@ static void
 _mesa_validate_program(GLcontext *ctx, GLuint program)
 {
    struct gl_shader_program *shProg;
-   shProg = _mesa_lookup_shader_program(ctx, program);
+
+   shProg = _mesa_lookup_shader_program_err(ctx, program, "glValidateProgram");
    if (!shProg) {
-      _mesa_error(ctx, GL_INVALID_VALUE, "glValidateProgram(program)");
       return;
    }
-   /* XXX temporary */
-   shProg->Validated = GL_TRUE;
 
-   /* From the GL spec:
+   if (!shProg->LinkStatus) {
+      shProg->Validated = GL_FALSE;
+      return;
+   }
+
+   /* From the GL spec, a program is invalid if any of these are true:
+
      any two active samplers in the current program object are of
      different types, but refer to the same texture image unit,
 
@@ -1555,6 +1559,8 @@ _mesa_validate_program(GLcontext *ctx, GLuint program)
      processing exceeds the combined limit on the total number of texture
      image units allowed.
    */
+
+   shProg->Validated = GL_TRUE;
 }