From: Jason Ekstrand <jason.ekstrand@intel.com>
Date: Wed, 11 Oct 2017 17:56:48 +0000 (-0700)
Subject: glsl/blob: Return false from ensure_can_read on overrun
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=7118851374074bd92887bfabd47ce39c9be412fd;p=mesa.git

glsl/blob: Return false from ensure_can_read on overrun

Otherwise, if you have a large read fail and then try to do a small
read, the small read may succeed even though it's at the wrong offset.

Reviewed-by: Nicolai Hähnle <nicolai.haehnle@amd.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
Cc: mesa-stable@lists.freedesktop.org
---

diff --git a/src/compiler/glsl/blob.c b/src/compiler/glsl/blob.c
index 3c4aed8524d..e837cdf2a0b 100644
--- a/src/compiler/glsl/blob.c
+++ b/src/compiler/glsl/blob.c
@@ -207,6 +207,9 @@ blob_reader_init(struct blob_reader *blob, uint8_t *data, size_t size)
 static bool
 ensure_can_read(struct blob_reader *blob, size_t size)
 {
+   if (blob->overrun)
+      return false;
+
    if (blob->current < blob->end && blob->end - blob->current >= size)
       return true;