From: José Fonseca <jfonseca@vmware.com>
Date: Fri, 19 Jul 2013 12:08:07 +0000 (+0100)
Subject: scons: Disallow undefined symbols in Xlib libGL.so.
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=719000bd7d7d227a721ee24ea49a55ab9a972b56;p=mesa.git

scons: Disallow undefined symbols in Xlib libGL.so.

It's not the first time that, due to missing build dependencies or
incomplete commits, we end up with a broken libGL.so that's missing
symbols, causing all tests to fail catastrophically.

Instead try to catch this sort of issues earlier.
---

diff --git a/src/gallium/targets/libgl-xlib/SConscript b/src/gallium/targets/libgl-xlib/SConscript
index 58ed6d4a30f..952ab62fdde 100644
--- a/src/gallium/targets/libgl-xlib/SConscript
+++ b/src/gallium/targets/libgl-xlib/SConscript
@@ -45,6 +45,9 @@ if env['llvm']:
     env.Append(CPPDEFINES = ['GALLIUM_LLVMPIPE'])
     env.Prepend(LIBS = [llvmpipe])
 
+# Disallow undefined symbols
+env.Append(SHLINKFLAGS = ['-Wl,-z,defs'])
+
 # libGL.so.1.5
 libgl_1_5 = env.SharedLibrary(
     target ='GL',
diff --git a/src/mesa/drivers/x11/SConscript b/src/mesa/drivers/x11/SConscript
index b0173bee94c..52952324386 100644
--- a/src/mesa/drivers/x11/SConscript
+++ b/src/mesa/drivers/x11/SConscript
@@ -31,6 +31,9 @@ sources = [
 	'xm_tri.c',
 ]
 
+# Disallow undefined symbols
+env.Append(SHLINKFLAGS = ['-Wl,-z,defs'])
+
 # libGL.so.1.6
 libgl_1_6 = env.SharedLibrary(
     target ='GL',