From: Richard Sandiford Date: Fri, 12 Jul 2019 10:33:52 +0000 (+0000) Subject: Relax vector_builder::elt sanity check X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=72ab1c51b607dd5446ee24ff9fce9178d6b811cb;p=gcc.git Relax vector_builder::elt sanity check I'd made it a precondition of vector_builder::elt that the encoding must have been fully populated and that all implicit elements are therefore defined. But for one of the AArch64 patches I'm working on, it'd be convenient to be able to look back at previous elements while building up the encoding. This patch therefore makes the assert specific to implicit elements only. 2019-07-12 Richard Sandiford gcc/ * vector-builder.h (vector_builder::elt): Allow already-supplied elements to be read back before building is complete. From-SVN: r273440 --- diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 7f01af33edb..43b52489921 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,8 @@ +2019-07-12 Richard Sandiford + + * vector-builder.h (vector_builder::elt): Allow already-supplied + elements to be read back before building is complete. + 2019-07-12 Eric Botcazou PR rtl-optimization/91136 diff --git a/gcc/vector-builder.h b/gcc/vector-builder.h index 9f95b01bc3b..aac8a875a58 100644 --- a/gcc/vector-builder.h +++ b/gcc/vector-builder.h @@ -199,14 +199,15 @@ template T vector_builder::elt (unsigned int i) const { - /* This only makes sense if the encoding has been fully populated. */ - gcc_checking_assert (encoded_nelts () <= this->length ()); - /* First handle elements that are already present in the underlying vector, regardless of whether they're part of the encoding or not. */ if (i < this->length ()) return (*this)[i]; + /* Extrapolation is only possible if the encoding has been fully + populated. */ + gcc_checking_assert (encoded_nelts () <= this->length ()); + /* Identify the pattern that contains element I and work out the index of the last encoded element for that pattern. */ unsigned int pattern = i % m_npatterns;