From: Samuel Tardieu Date: Fri, 7 Dec 2007 18:03:20 +0000 (+0000) Subject: re PR ada/21346 (Ada.Directories.Compose raises exception if Containing_Directory... X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=72f69ddf21cbf51560e6da8d9a534d25a1e72a61;p=gcc.git re PR ada/21346 (Ada.Directories.Compose raises exception if Containing_Directory is empty string) gcc/ada/ PR ada/21346 * a-direct.adb (Compose): Containing_Directory can be an empty string. gcc/testsuite/ PR ada/21346 * gnat.dg/compose.adb: New test. From-SVN: r130692 --- diff --git a/gcc/ada/ChangeLog b/gcc/ada/ChangeLog index 0b1afbc785a..49f226f4021 100644 --- a/gcc/ada/ChangeLog +++ b/gcc/ada/ChangeLog @@ -14,6 +14,9 @@ when an access to constant is used to initialize an access value. + PR ada/21346 + * a-direct.adb (Compose): Containing_Directory can be an empty string. + 2007-12-07 Olivier Hainque PR ada/34173 diff --git a/gcc/ada/a-direct.adb b/gcc/ada/a-direct.adb index 1d7ea552be2..52ad1b306d8 100644 --- a/gcc/ada/a-direct.adb +++ b/gcc/ada/a-direct.adb @@ -155,7 +155,9 @@ package body Ada.Directories is begin -- First, deal with the invalid cases - if not Is_Valid_Path_Name (Containing_Directory) then + if Containing_Directory /= "" + and then not Is_Valid_Path_Name (Containing_Directory) + then raise Name_Error; elsif @@ -176,7 +178,7 @@ package body Ada.Directories is -- Add a directory separator if needed - if Result (Last) /= Dir_Separator then + if Last /= 0 and then Result (Last) /= Dir_Separator then Last := Last + 1; Result (Last) := Dir_Separator; end if; diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 1b0fbbd0019..62a7a15a3e1 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -15,6 +15,9 @@ * gnat.dg/specs/access_constant_decl.ads: New test. + PR ada/21346 + * gnat.dg/compose.adb: New test. + 2007-12-07 Olivier Hainque PR ada/34173 diff --git a/gcc/testsuite/gnat.dg/compose.adb b/gcc/testsuite/gnat.dg/compose.adb new file mode 100644 index 00000000000..4ee3c57f668 --- /dev/null +++ b/gcc/testsuite/gnat.dg/compose.adb @@ -0,0 +1,11 @@ +-- { dg-do run } +with Ada.Directories; +with Ada.Text_IO; + +procedure Compose is + Result : constant String := Ada.Directories.Compose (Name => "foo", + Extension => "txt"); + pragma Unreferenced (Result); +begin + null; +end Compose;