From: Kenneth Graunke Date: Tue, 29 Nov 2016 09:30:18 +0000 (-0800) Subject: i965: Drop BRW_NEW_PUSH_CONSTANT_ALLOCATION from CS packets. X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=731b577cc6d0294a4ef1266996a53bbc30713d6e;p=mesa.git i965: Drop BRW_NEW_PUSH_CONSTANT_ALLOCATION from CS packets. I don't think CS push constant uploading uses the section of L3 controlled by 3DSTATE_PUSH_CONSTANT_ALLOC_XS. So I don't think it needs to be re-emitted when that space is reallocated. The programming note in gen7_allocate_push_constants doesn't indicate this is necessary, at least. Reviewed-by: Chris Forbes --- diff --git a/src/mesa/drivers/dri/i965/gen7_cs_state.c b/src/mesa/drivers/dri/i965/gen7_cs_state.c index cbb6bb1ef26..26e4264018f 100644 --- a/src/mesa/drivers/dri/i965/gen7_cs_state.c +++ b/src/mesa/drivers/dri/i965/gen7_cs_state.c @@ -133,8 +133,7 @@ const struct brw_tracked_state gen7_cs_push_constants = { .brw = BRW_NEW_BATCH | BRW_NEW_BLORP | BRW_NEW_COMPUTE_PROGRAM | - BRW_NEW_CS_PROG_DATA | - BRW_NEW_PUSH_CONSTANT_ALLOCATION, + BRW_NEW_CS_PROG_DATA, }, .emit = gen7_upload_cs_push_constants, }; diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c b/src/mesa/drivers/dri/i965/genX_state_upload.c index 3921a6f2d4b..64ba3577383 100644 --- a/src/mesa/drivers/dri/i965/genX_state_upload.c +++ b/src/mesa/drivers/dri/i965/genX_state_upload.c @@ -3735,7 +3735,6 @@ static const struct brw_tracked_state genX(cs_state) = { .brw = BRW_NEW_BATCH | BRW_NEW_BLORP | BRW_NEW_CS_PROG_DATA | - BRW_NEW_PUSH_CONSTANT_ALLOCATION | BRW_NEW_SAMPLER_STATE_TABLE | BRW_NEW_SURFACES, },