From: Pedro Alves <palves@redhat.com>
Date: Fri, 19 Apr 2013 15:33:58 +0000 (+0000)
Subject: -Wpointer-sign: xcoffread.c.
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=745eb4fdb2c0c7e68cdb9672412ad8ceca7347f2;p=binutils-gdb.git

-Wpointer-sign: xcoffread.c.

../../src/gdb/xcoffread.c: In function ‘xcoff_initial_scan’:
../../src/gdb/xcoffread.c:2982:17: error: pointer targets in assignment differ in signedness [-Werror=pointer-sign]

'debugsec' is a 'bfd_byte *', holding the result of a
bfd_get_full_section_contents.  'info->debugsec' holds the same
contents throughout the whole xcoff read, and everywhere it's used to
read symbol names.  Simply adding a cast feels appropriate.

gdb/
2013-04-19  Pedro Alves  <palves@redhat.com>

	* xcoffread.c (xcoff_initial_scan): Add cast to 'char *'.
---

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 47a8ac2c188..a28fdad66c2 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2013-04-19  Pedro Alves  <palves@redhat.com>
+
+	* xcoffread.c (xcoff_initial_scan): Add cast to 'char *'.
+
 2013-04-19  Pedro Alves  <palves@redhat.com>
 
 	* coff-pe-read.c (read_pe_exported_syms): Handle strings as char.
diff --git a/gdb/xcoffread.c b/gdb/xcoffread.c
index 60135514ac4..2b5f9b77b10 100644
--- a/gdb/xcoffread.c
+++ b/gdb/xcoffread.c
@@ -2979,7 +2979,7 @@ xcoff_initial_scan (struct objfile *objfile, int symfile_flags)
 		  }
 	      }
 	  }
-	info->debugsec = debugsec;
+	info->debugsec = (char *) debugsec;
       }
     }