From: Christoph Brill Date: Mon, 25 Feb 2008 19:24:00 +0000 (+0100) Subject: [r300] Sync the names for Z-Buffer registers with the AMD spec X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=74ae5a875d6b3f1ffea2ac09c6ef0062d4980f15;p=mesa.git [r300] Sync the names for Z-Buffer registers with the AMD spec This patch tries to get the Z-Buffer register names in sync with the AMD spec so that talking to AMD engineers is much simpler. --- diff --git a/src/mesa/drivers/dri/r300/r300_cmdbuf.c b/src/mesa/drivers/dri/r300/r300_cmdbuf.c index ae4bc64934d..dad81bac945 100644 --- a/src/mesa/drivers/dri/r300/r300_cmdbuf.c +++ b/src/mesa/drivers/dri/r300/r300_cmdbuf.c @@ -429,9 +429,9 @@ void r300InitCmdBuf(r300ContextPtr r300) cmdpacket0(R300_RB3D_ZSTENCIL_CNTL_0, 3); ALLOC_STATE(zstencil_format, always, 5, 0); r300->hw.zstencil_format.cmd[0] = - cmdpacket0(R300_RB3D_ZSTENCIL_FORMAT, 4); + cmdpacket0(ZB_FORMAT, 4); ALLOC_STATE(zb, always, R300_ZB_CMDSIZE, 0); - r300->hw.zb.cmd[R300_ZB_CMD_0] = cmdpacket0(R300_RB3D_DEPTHOFFSET, 2); + r300->hw.zb.cmd[R300_ZB_CMD_0] = cmdpacket0(ZB_DEPTHOFFSET, 2); ALLOC_STATE(zb_depthclearvalue, always, 2, 0); r300->hw.zb_depthclearvalue.cmd[0] = cmdpacket0(ZB_DEPTHCLEARVALUE, 1); ALLOC_STATE(unk4F30, always, 3, 0); diff --git a/src/mesa/drivers/dri/r300/r300_emit.c b/src/mesa/drivers/dri/r300/r300_emit.c index 40d7113d7f9..761b618e9fe 100644 --- a/src/mesa/drivers/dri/r300/r300_emit.c +++ b/src/mesa/drivers/dri/r300/r300_emit.c @@ -544,8 +544,8 @@ void r300EmitCacheFlush(r300ContextPtr rmesa) reg_start(R300_RB3D_DSTCACHE_CTLSTAT, 0); e32(R300_RB3D_DSTCACHE_UNKNOWN_0A); - reg_start(R300_RB3D_ZCACHE_CTLSTAT, 0); - e32(R300_RB3D_ZCACHE_UNKNOWN_03); + reg_start(ZB_ZCACHE_CTLSTAT, 0); + e32(ZB_ZCACHE_CTLSTAT_ZC_FREE_FREE); } diff --git a/src/mesa/drivers/dri/r300/r300_reg.h b/src/mesa/drivers/dri/r300/r300_reg.h index 6ceb99db50b..4c44d079ba1 100644 --- a/src/mesa/drivers/dri/r300/r300_reg.h +++ b/src/mesa/drivers/dri/r300/r300_reg.h @@ -1688,19 +1688,24 @@ USE OR OTHER DEALINGS IN THE SOFTWARE. # define R300_RB3D_ZS1_BACK_ZPASS_OP_SHIFT 21 # define R300_RB3D_ZS1_BACK_ZFAIL_OP_SHIFT 24 -#define R300_RB3D_ZSTENCIL_CNTL_2 0x4F08 -# define R300_RB3D_ZS2_STENCIL_REF_SHIFT 0 -# define R300_RB3D_ZS2_STENCIL_MASK 0xFF -# define R300_RB3D_ZS2_STENCIL_MASK_SHIFT 8 -# define R300_RB3D_ZS2_STENCIL_WRITE_MASK_SHIFT 16 +#define ZB_STENCILREFMASK 0x4f08 +# define ZB_STENCILREFMASK_STENCILREF_SHIFT 0 +# define ZB_STENCILREFMASK_STENCILREF_MASK 0x000000ff +# define ZB_STENCILREFMASK_STENCILMASK_SHIFT 8 +# define ZB_STENCILREFMASK_STENCILMASK_MASK 0x0000ff00 +# define ZB_STENCILREFMASK_STENCILWRITEMASK_SHIFT 16 +# define ZB_STENCILREFMASK_STENCILWRITEMASK_MASK 0xffff0000 /* gap */ -#define R300_RB3D_ZSTENCIL_FORMAT 0x4F10 -# define R300_DEPTH_FORMAT_16BIT_INT_Z (0 << 0) -# define R300_DEPTH_FORMAT_24BIT_INT_Z (2 << 0) - /* 16 bit format or some aditional bit ? */ -# define R300_DEPTH_FORMAT_UNK32 (32 << 0) +#define ZB_FORMAT 0x4f10 +# define ZB_FORMAR_DEPTHFORMAT_16BIT_INT_Z (0 << 0) +# define ZB_FORMAR_DEPTHFORMAT_16BIT_13E3 (1 << 0) +# define ZB_FORMAR_DEPTHFORMAT_24BIT_INT_Z (2 << 0) +/* reserved up to (15 << 0) */ +# define ZB_FORMAR_INVERT_13E3_LEADING_ONES (0 << 4) +# define ZB_FORMAR_INVERT_13E3_LEADING_ZEROS (1 << 4) +# define ZB_FORMAR_PEQ8_UNUSED (1 << 5) #define R300_RB3D_EARLY_Z 0x4F14 # define R300_EARLY_Z_DISABLE (0 << 0) @@ -1708,9 +1713,13 @@ USE OR OTHER DEALINGS IN THE SOFTWARE. /* gap */ -#define R300_RB3D_ZCACHE_CTLSTAT 0x4F18 /* GUESS */ -# define R300_RB3D_ZCACHE_UNKNOWN_01 0x1 -# define R300_RB3D_ZCACHE_UNKNOWN_03 0x3 +#define ZB_ZCACHE_CTLSTAT 0x4f18 +# define ZB_ZCACHE_CTLSTAT_ZC_FLUSH_NO_EFFECT (0 << 0) +# define ZB_ZCACHE_CTLSTAT_ZC_FLUSH_FLUSH_AND_FREE (1 << 0) +# define ZB_ZCACHE_CTLSTAT_ZC_FREE_NO_EFFECT (0 << 1) +# define ZB_ZCACHE_CTLSTAT_ZC_FREE_FREE (1 << 1) +# define ZB_ZCACHE_CTLSTAT_ZC_BUSY_IDLE (0 << 1) +# define ZB_ZCACHE_CTLSTAT_ZC_BUSY_BUSY (1 << 1) #define R300_ZB_BW_CNTL 0x4f1c # define R300_HIZ_DISABLE (0 << 0) @@ -1756,14 +1765,23 @@ USE OR OTHER DEALINGS IN THE SOFTWARE. /* gap */ -#define R300_RB3D_DEPTHOFFSET 0x4F20 -#define R300_RB3D_DEPTHPITCH 0x4F24 -# define R300_DEPTHPITCH_MASK 0x00001FF8 /* GUESS */ -# define R300_DEPTH_TILE_ENABLE (1 << 16) /* GUESS */ -# define R300_DEPTH_MICROTILE_ENABLE (1 << 17) /* GUESS */ -# define R300_DEPTH_ENDIAN_NO_SWAP (0 << 18) /* GUESS */ -# define R300_DEPTH_ENDIAN_WORD_SWAP (1 << 18) /* GUESS */ -# define R300_DEPTH_ENDIAN_DWORD_SWAP (2 << 18) /* GUESS */ +/* Z Buffer Address Offset. + * Bits 31 to 5 are used for aligned Z buffer address offset for macro tiles. + */ +#define ZB_DEPTHOFFSET 0x4f20 + +/* Z Buffer Pitch and Endian Control */ +#define ZB_DEPTHPITCH 0x4f24 +# define R300_DEPTHPITCH_MASK 0x00001FF8 /* TODO: should be (13:2) */ +# define ZB_DEPTHPITCH_DEPTHMACROTILE_DISABLE (0 << 16) +# define ZB_DEPTHPITCH_DEPTHMACROTILE_ENABLE (1 << 16) +# define ZB_DEPTHPITCH_DEPTHMICROTILE_LINEAR (0 << 17) +# define ZB_DEPTHPITCH_DEPTHMICROTILE_TILED (1 << 17) +# define ZB_DEPTHPITCH_DEPTHMICROTILE_TILED_SQUARE (2 << 17) +# define ZB_DEPTHPITCH_DEPTHENDIAN_NO_SWAP (0 << 18) +# define ZB_DEPTHPITCH_DEPTHENDIAN_WORD_SWAP (1 << 18) +# define ZB_DEPTHPITCH_DEPTHENDIAN_DWORD_SWAP (2 << 18) +# define ZB_DEPTHPITCH_DEPTHENDIAN_HALF_DWORD_SWAP (3 << 18) /* Z Buffer Clear Value */ #define ZB_DEPTHCLEARVALUE 0x4f28 @@ -1774,12 +1792,44 @@ USE OR OTHER DEALINGS IN THE SOFTWARE. /* Hierarchical Z Read Index */ #define ZB_HIZ_RDINDEX 0x4f48 +/* Hierarchical Z Data */ +#define ZB_HIZ_DWORD 0x4f4c + /* Hierarchical Z Write Index */ #define ZB_HIZ_WRINDEX 0x4f50 /* Hierarchical Z Pitch */ #define ZB_HIZ_PITCH 0x4f54 +/* Z Buffer Z Pass Counter Data */ +#define ZB_ZPASS_DATA 0x4f58 + +/* Z Buffer Z Pass Counter Address */ +#define ZB_ZPASS_ADDR 0x4f5c + +/* Depth buffer X and Y coordinate offset */ +#define ZB_DEPTHXY_OFFSET 0x4f60 +# define ZB_DEPTHX_OFFSET_SHIFT 1 +# define ZB_DEPTHX_OFFSET_MASK 0x000007FE +# define ZB_DEPTHY_OFFSET_SHIFT 17 +# define ZB_DEPTHY_OFFSET_MASK 0x07FE0000 + +/* Sets the fifo sizes */ +#define ZB_FIFO_SIZE 0x4fd0 +# define ZB_FIFO_SIZE_OP_FIFO_SIZE_FULL (0 << 0) +# define ZB_FIFO_SIZE_OP_FIFO_SIZE_HALF (1 << 0) +# define ZB_FIFO_SIZE_OP_FIFO_SIZE_QUATER (2 << 0) +# define ZB_FIFO_SIZE_OP_FIFO_SIZE_EIGTHS (4 << 0) + +/* Stencil Reference Value and Mask for backfacing quads */ +#define ZB_STENCILREFMASK_BF 0x4fd4 +# define ZB_STENCILREFMASK_BF_STENCILREF_SHIFT 0 +# define ZB_STENCILREFMASK_BF_STENCILREF_MASK 0x000000ff +# define ZB_STENCILREFMASK_BF_STENCILMASK_SHIFT 8 +# define ZB_STENCILREFMASK_BF_STENCILMASK_MASK 0x0000ff00 +# define ZB_STENCILREFMASK_BF_STENCILWRITEMASK_SHIFT 16 +# define ZB_STENCILREFMASK_BF_STENCILWRITEMASK_MASK 0xffff0000 + /* BEGIN: Vertex program instruction set */ /* Every instruction is four dwords long: diff --git a/src/mesa/drivers/dri/r300/r300_state.c b/src/mesa/drivers/dri/r300/r300_state.c index 5fc1dcbe38b..cc4179738ce 100644 --- a/src/mesa/drivers/dri/r300/r300_state.c +++ b/src/mesa/drivers/dri/r300/r300_state.c @@ -363,18 +363,16 @@ static void r300SetEarlyZState(GLcontext * ctx) R300_STATECHANGE(r300, zstencil_format); switch (ctx->Visual.depthBits) { case 16: - r300->hw.zstencil_format.cmd[1] = R300_DEPTH_FORMAT_16BIT_INT_Z; + r300->hw.zstencil_format.cmd[1] = ZB_FORMAR_DEPTHFORMAT_16BIT_INT_Z; break; case 24: - r300->hw.zstencil_format.cmd[1] = R300_DEPTH_FORMAT_24BIT_INT_Z; + r300->hw.zstencil_format.cmd[1] = ZB_FORMAR_DEPTHFORMAT_24BIT_INT_Z; break; default: fprintf(stderr, "Error: Unsupported depth %d... exiting\n", ctx->Visual.depthBits); _mesa_exit(-1); } - // r300->hw.zstencil_format.cmd[1] |= R300_DEPTH_FORMAT_UNK32; - if (ctx->Color.AlphaEnabled && ctx->Color.AlphaFunc != GL_ALWAYS) /* disable early Z */ r300->hw.zstencil_format.cmd[2] = R300_EARLY_Z_DISABLE; @@ -822,13 +820,13 @@ static void r300StencilFuncSeparate(GLcontext * ctx, GLenum face, r300ContextPtr rmesa = R300_CONTEXT(ctx); GLuint refmask = (((ctx->Stencil. - Ref[0] & 0xff) << R300_RB3D_ZS2_STENCIL_REF_SHIFT) | ((ctx-> + Ref[0] & 0xff) << ZB_STENCILREFMASK_STENCILREF_SHIFT) | ((ctx-> Stencil. ValueMask [0] & 0xff) << - R300_RB3D_ZS2_STENCIL_MASK_SHIFT)); + ZB_STENCILREFMASK_STENCILMASK_SHIFT)); GLuint flag; @@ -840,9 +838,8 @@ static void r300StencilFuncSeparate(GLcontext * ctx, GLenum face, R300_RB3D_ZS1_BACK_FUNC_SHIFT)); rmesa->hw.zs.cmd[R300_ZS_CNTL_2] &= - ~((R300_RB3D_ZS2_STENCIL_MASK << - R300_RB3D_ZS2_STENCIL_REF_SHIFT) | - (R300_RB3D_ZS2_STENCIL_MASK << R300_RB3D_ZS2_STENCIL_MASK_SHIFT)); + ~((ZB_STENCILREFMASK_STENCILREF_MASK << ZB_STENCILREFMASK_STENCILREF_SHIFT) | + (ZB_STENCILREFMASK_STENCILMASK_MASK << ZB_STENCILREFMASK_STENCILMASK_SHIFT)); flag = translate_func(ctx->Stencil.Function[0]); rmesa->hw.zs.cmd[R300_ZS_CNTL_1] |= @@ -862,11 +859,11 @@ static void r300StencilMaskSeparate(GLcontext * ctx, GLenum face, GLuint mask) R300_STATECHANGE(rmesa, zs); rmesa->hw.zs.cmd[R300_ZS_CNTL_2] &= - ~(R300_RB3D_ZS2_STENCIL_MASK << - R300_RB3D_ZS2_STENCIL_WRITE_MASK_SHIFT); + ~(ZB_STENCILREFMASK_STENCILMASK_MASK << + ZB_STENCILREFMASK_STENCILWRITEMASK_SHIFT); rmesa->hw.zs.cmd[R300_ZS_CNTL_2] |= (ctx->Stencil. - WriteMask[0] & 0xff) << R300_RB3D_ZS2_STENCIL_WRITE_MASK_SHIFT; + WriteMask[0] & 0xff) << ZB_STENCILREFMASK_STENCILWRITEMASK_SHIFT; } static void r300StencilOpSeparate(GLcontext * ctx, GLenum face, @@ -914,10 +911,10 @@ static void r300ClearStencil(GLcontext * ctx, GLint s) rmesa->state.stencil.clear = ((GLuint) (ctx->Stencil.Clear & 0xff) | - (R300_RB3D_ZS2_STENCIL_MASK << - R300_RB3D_ZS2_STENCIL_MASK_SHIFT) | ((ctx->Stencil. + (ZB_STENCILREFMASK_STENCILMASK_MASK << + ZB_STENCILREFMASK_STENCILMASK_SHIFT) | ((ctx->Stencil. WriteMask[0] & 0xff) << - R300_RB3D_ZS2_STENCIL_WRITE_MASK_SHIFT)); + ZB_STENCILREFMASK_STENCILMASK_SHIFT)); } /* ============================================================= @@ -1990,11 +1987,11 @@ static void r300ResetHwState(r300ContextPtr r300) if (r300->radeon.sarea->tiling_enabled) { /* XXX: Turn off when clearing buffers ? */ - r300->hw.zb.cmd[R300_ZB_PITCH] |= R300_DEPTH_TILE_ENABLE; + r300->hw.zb.cmd[R300_ZB_PITCH] |= ZB_DEPTHPITCH_DEPTHMACROTILE_ENABLE; if (ctx->Visual.depthBits == 24) r300->hw.zb.cmd[R300_ZB_PITCH] |= - R300_DEPTH_MICROTILE_ENABLE; + ZB_DEPTHPITCH_DEPTHMICROTILE_TILED; } r300->hw.zb_depthclearvalue.cmd[1] = 0; @@ -2182,12 +2179,12 @@ void r300InitState(r300ContextPtr r300) switch (ctx->Visual.depthBits) { case 16: r300->state.depth.scale = 1.0 / (GLfloat) 0xffff; - depth_fmt = R300_DEPTH_FORMAT_16BIT_INT_Z; + depth_fmt = ZB_FORMAR_DEPTHFORMAT_16BIT_INT_Z; r300->state.stencil.clear = 0x00000000; break; case 24: r300->state.depth.scale = 1.0 / (GLfloat) 0xffffff; - depth_fmt = R300_DEPTH_FORMAT_24BIT_INT_Z; + depth_fmt = ZB_FORMAR_DEPTHFORMAT_24BIT_INT_Z; r300->state.stencil.clear = 0x00ff0000; break; default: