From: Kenneth Graunke Date: Tue, 11 Mar 2014 06:55:21 +0000 (-0700) Subject: i965/fs: Invalidate live intervals when demoting uniforms to pull params. X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=7554539d7ebbed5f5048ddeadaf5a5dc6e2ce2a6;p=mesa.git i965/fs: Invalidate live intervals when demoting uniforms to pull params. Normally, nothing uses live intervals at this point, so this isn't necessary. However, dump_instructions() calculates them and uses them to show register pressure. So, calling dump_instructions() in this area of the code would segfault due to the arrays being the wrong size. This is not a candidate for stable branches because it only serves to fix internal debugging code that you manually have to invoke by altering the source code or using gdb. Signed-off-by: Kenneth Graunke Reviewed-by: Matt Turner --- diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index 3fab30953c1..0945343a03d 100644 --- a/src/mesa/drivers/dri/i965/brw_fs.cpp +++ b/src/mesa/drivers/dri/i965/brw_fs.cpp @@ -1883,6 +1883,7 @@ fs_visitor::move_uniform_array_access_to_pull_constants() inst->src[i].reladdr = NULL; } } + invalidate_live_intervals(); } /** @@ -1968,6 +1969,7 @@ fs_visitor::setup_pull_constants() inst->src[i].set_smear(pull_index & 3); } } + invalidate_live_intervals(); } bool