From: Pouya Fotouhi <pfotouhi@ucdavis.edu>
Date: Wed, 12 Aug 2020 06:31:29 +0000 (-0700)
Subject: mem-ruby: Fix debug prints for regular Stores
X-Git-Tag: v20.1.0.0~318
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=762153a421407def012eb9620cef695faa3f2df8;p=gem5.git

mem-ruby: Fix debug prints for regular Stores

In the updated implementation of LL/SC (27103) the default value
of success was changed, which results in printing "SC_Failed" for
any regular stores.

Change-Id: I4f2e0b26233ce0cbdf948aadd19c9d81bf18bec0
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/32514
Reviewed-by: Jason Lowe-Power <power.jg@gmail.com>
Reviewed-by: Giacomo Travaglini <giacomo.travaglini@arm.com>
Maintainer: Jason Lowe-Power <power.jg@gmail.com>
Tested-by: kokoro <noreply+kokoro@google.com>
---

diff --git a/src/mem/ruby/system/Sequencer.cc b/src/mem/ruby/system/Sequencer.cc
index aa134f4fa..42398e23e 100644
--- a/src/mem/ruby/system/Sequencer.cc
+++ b/src/mem/ruby/system/Sequencer.cc
@@ -368,7 +368,7 @@ Sequencer::writeCallback(Addr address, DataBlock& data,
             (seq_req.m_type != RubyRequestType_Load_Linked) &&
             (seq_req.m_type != RubyRequestType_IFETCH)) {
             // LL/SC support (tested with ARMv8)
-            bool success = false;
+            bool success = true;
 
             if (seq_req.m_type != RubyRequestType_Store_Conditional) {
                 // Regular stores to addresses being monitored