From: Ian Romanick <ian.d.romanick@intel.com>
Date: Thu, 29 May 2014 00:05:14 +0000 (-0700)
Subject: glsl: Validate that built-in uniforms have backing state
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=77005cfabd263e593cec37cd5933443785d6b9aa;p=mesa.git

glsl: Validate that built-in uniforms have backing state

All built-in uniforms are supposed to be backed by some GL state.  The
state_slots field describes this backing state.

This helped me track down a bug in a later patch.

Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
Reviewed-by: Matt Turner <mattst88@gmail.com>
Acked-by: Anuj Phogat <anuj.phogat@gmail.com>
---

diff --git a/src/glsl/ir_validate.cpp b/src/glsl/ir_validate.cpp
index 97a581dc2d5..5ed8abba0b4 100644
--- a/src/glsl/ir_validate.cpp
+++ b/src/glsl/ir_validate.cpp
@@ -700,6 +700,14 @@ ir_validate::visit(ir_variable *ir)
       abort();
    }
 
+   if (ir->data.mode == ir_var_uniform
+       && strncmp(ir->name, "gl_", 3) == 0
+       && ir->state_slots == NULL) {
+      printf("built-in uniform has no state\n");
+      ir->print();
+      abort();
+   }
+
    return visit_continue;
 }