From: Alan Modra <amodra@gmail.com>
Date: Tue, 15 Oct 2019 01:28:11 +0000 (+1030)
Subject: PR25100, Compile fails in elf64-ppc.c because of single equal sign instead of double... 
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=779f2ae733cc4b4da666a2405eb77ec70df2c772;p=binutils-gdb.git

PR25100, Compile fails in elf64-ppc.c because of single equal sign instead of double equal for comparison

	PR 25100
	* elf64-ppc.c (sfpr_define): Delete dead code that triggered a warning.
---

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 4d8db193f2e..40ddfa14d5e 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,8 @@
+2019-10-15  Alan Modra  <amodra@gmail.com>
+
+	PR 25100
+	* elf64-ppc.c (sfpr_define): Delete dead code that triggered a warning.
+
 2019-10-15  Alan Modra  <amodra@gmail.com>
 
 	* bfd.c (bfd_check_compression_header): Check for powers of two
diff --git a/bfd/elf64-ppc.c b/bfd/elf64-ppc.c
index 2731e78618d..4ece6fbde01 100644
--- a/bfd/elf64-ppc.c
+++ b/bfd/elf64-ppc.c
@@ -5837,9 +5837,7 @@ sfpr_define (struct bfd_link_info *info,
 	      s = elf_link_hash_lookup (&htab->elf, buf, TRUE, TRUE, FALSE);
 	      if (s == NULL)
 		return FALSE;
-	      if (s->root.type == bfd_link_hash_new
-		  || (s->root.type = bfd_link_hash_defined
-		      && s->root.u.def.section == stub_sec))
+	      if (s->root.type == bfd_link_hash_new)
 		{
 		  s->root.type = bfd_link_hash_defined;
 		  s->root.u.def.section = stub_sec;