From: Kenneth Graunke Date: Mon, 17 Oct 2011 23:41:57 +0000 (-0700) Subject: mesa: Remove unnecessary and incorrect TexEnv parameter validation. X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=7a86bf816c3eb977a5d7e558e85f00f8f2b9868a;p=mesa.git mesa: Remove unnecessary and incorrect TexEnv parameter validation. For GL_RGB_SCALE and GL_ALPHA_SCALE targets, the API wrapper code attempts to ensure the parameter is 1.0, 2.0, or 4.0. This is unnecessary: set_combiner_scale in texenv.c (called by _mesa_TexEnvfv) already checks this and raises an appropriate error. It's also incorrect: For glTexEnvx, the API validation code directly compares the GLfixed input parameter with a floating point constant, prior to converting fixed-point to floating point. Fixes an issue in the OpenGL ES 1.1 conformance suite. Signed-off-by: Kenneth Graunke Reviewed-by: Ian Romanick --- diff --git a/src/mesa/main/APIspec.xml b/src/mesa/main/APIspec.xml index 574480e284d..a92bb437c91 100644 --- a/src/mesa/main/APIspec.xml +++ b/src/mesa/main/APIspec.xml @@ -631,12 +631,6 @@ - - - - - -