From: Tobias Ulmer <tobiasu@tmux.org>
Date: Fri, 1 Dec 2017 08:55:19 +0000 (+1030)
Subject: Check return value of bfd_new_link_order
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=7b2d20948528f94b405af3e951931758e92e8e4d;p=binutils-gdb.git

Check return value of bfd_new_link_order

	* ldwrite.c (build_link_order): Check return value of all
	bfd_new_link_order calls.
---

diff --git a/ld/ChangeLog b/ld/ChangeLog
index e0873827ba9..0d1d3c7b222 100644
--- a/ld/ChangeLog
+++ b/ld/ChangeLog
@@ -1,3 +1,8 @@
+2017-12-01  Tobias Ulmer  <tobiasu@tmux.org>
+
+	* ldwrite.c (build_link_order): Check return value of all
+	bfd_new_link_order calls.
+
 2017-12-01  Alan Modra  <amodra@gmail.com>
 
 	* testsuite/ld-elfweak/alias.c,
diff --git a/ld/ldwrite.c b/ld/ldwrite.c
index 1cd111d20a3..1abea29bd30 100644
--- a/ld/ldwrite.c
+++ b/ld/ldwrite.c
@@ -254,6 +254,8 @@ build_link_order (lang_statement_union_type *statement)
 
 	    link_order = bfd_new_link_order (link_info.output_bfd,
 					     output_section);
+	    if (link_order == NULL)
+	      einfo (_("%P%F: bfd_new_link_order failed\n"));
 
 	    if ((i->flags & SEC_NEVER_LOAD) != 0
 		&& (i->flags & SEC_DEBUGGING) == 0)
@@ -293,6 +295,8 @@ build_link_order (lang_statement_union_type *statement)
 
 	link_order = bfd_new_link_order (link_info.output_bfd,
 					 output_section);
+	if (link_order == NULL)
+	  einfo (_("%P%F: bfd_new_link_order failed\n"));
 	link_order->type = bfd_data_link_order;
 	link_order->size = statement->padding_statement.size;
 	link_order->offset = statement->padding_statement.output_offset;