From: Vinson Lee <vlee@freedesktop.org>
Date: Mon, 3 Jun 2013 06:16:42 +0000 (-0700)
Subject: mesa: Prevent possible out-of-bounds read by save_SamplerParameterfv.
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=7bafd88c153e395274b632e7eae4bc9fc3aec1d2;p=mesa.git

mesa: Prevent possible out-of-bounds read by save_SamplerParameterfv.

Fixes "Out-of-bounds access" defect reported by Coverity.

Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Brian Paul <brianp@vmware.com>
---

diff --git a/src/mesa/main/dlist.c b/src/mesa/main/dlist.c
index c37b15ee64b..18e3eb76037 100644
--- a/src/mesa/main/dlist.c
+++ b/src/mesa/main/dlist.c
@@ -7056,7 +7056,10 @@ save_SamplerParameterfv(GLuint sampler, GLenum pname, const GLfloat *params)
 static void GLAPIENTRY
 save_SamplerParameterf(GLuint sampler, GLenum pname, GLfloat param)
 {
-   save_SamplerParameterfv(sampler, pname, &param);
+   GLfloat parray[4];
+   parray[0] = param;
+   parray[1] = parray[2] = parray[3] = 0.0F;
+   save_SamplerParameterfv(sampler, pname, parray);
 }
 
 static void GLAPIENTRY