From: Michael Snyder Date: Tue, 31 Jul 2007 21:56:00 +0000 (+0000) Subject: 2007-07-31 Michael Snyder X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=7c6e0d4812e589c911fd4d5f6c336f56f8ef2686;p=binutils-gdb.git 2007-07-31 Michael Snyder * f-valprint.c (info_common_command): Bail out to prevent null pointer deref. Break up a long line. --- diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 4acf4e7c380..346f9155e80 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,8 @@ 2007-07-31 Michael Snyder + * f-valprint.c (info_common_command): Bail out to prevent null + pointer deref. Break up a long line. + * exec.c (xfer_memory): Remove redundant condition from 'if'. * symfile.c (reread_separate_symbols): Free xmalloced memory. diff --git a/gdb/f-valprint.c b/gdb/f-valprint.c index 41a97716116..2ba10b4536f 100644 --- a/gdb/f-valprint.c +++ b/gdb/f-valprint.c @@ -671,7 +671,8 @@ info_common_command (char *comname, int from_tty) be any minimal symbols in the middle of a function. FIXME: (Not necessarily true. What about text labels) */ - struct minimal_symbol *msymbol = lookup_minimal_symbol_by_pc (get_frame_pc (fi)); + struct minimal_symbol *msymbol = + lookup_minimal_symbol_by_pc (get_frame_pc (fi)); if (msymbol != NULL && (SYMBOL_VALUE_ADDRESS (msymbol) @@ -687,6 +688,8 @@ info_common_command (char *comname, int from_tty) if (msymbol != NULL) funname = DEPRECATED_SYMBOL_NAME (msymbol); + else /* Got no 'funname', code below will fail. */ + error (_("No function found for frame.")); } /* If comname is NULL, we assume the user wishes to see the