From: Eli Bendersky <eliben@gmail.com>
Date: Wed, 8 Jul 2020 00:44:33 +0000 (-0700)
Subject: Fix formatting and add comment in test
X-Git-Tag: v0.27~18
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=7ca16680f4eb01e6b6bbbc222f18de56460426d1;p=pyelftools.git

Fix formatting and add comment in test
---

diff --git a/test/test_dwarf_expr.py b/test/test_dwarf_expr.py
index 1e9949e..308d872 100644
--- a/test/test_dwarf_expr.py
+++ b/test/test_dwarf_expr.py
@@ -53,11 +53,11 @@ class TestExprDumper(unittest.TestCase):
         self.assertEqual(self.visitor.dump_expr([0x1d, 0x1e, 0x1d, 0x1e, 0x1d, 0x1e]),
             'DW_OP_mod; DW_OP_mul; DW_OP_mod; DW_OP_mul; DW_OP_mod; DW_OP_mul')
 
+        # 0xe0 maps to both DW_OP_GNU_push_tls_address and DW_OP_lo_user, so
+        # check for both to prevent non-determinism.
         self.assertIn(self.visitor.dump_expr([0x08, 0x0f, 0xe0]),
                       ('DW_OP_const1u: 15; DW_OP_GNU_push_tls_address',
-                       'DW_OP_const1u: 15; DW_OP_lo_user',
-                       )
-                      )
+                       'DW_OP_const1u: 15; DW_OP_lo_user'))
 
 
 class TestParseExpr(unittest.TestCase):
@@ -79,10 +79,11 @@ class TestParseExpr(unittest.TestCase):
 
         lst = p.parse_expr([0xe0])
         self.assertEqual(len(lst), 1)
+        # 0xe0 maps to both DW_OP_GNU_push_tls_address and DW_OP_lo_user, so
+        # check for both to prevent non-determinism.
         self.assertIn(lst[0], [
             DWARFExprOp(op=0xe0, op_name='DW_OP_GNU_push_tls_address', args=[]),
-            DWARFExprOp(op=0xe0, op_name='DW_OP_lo_user', args=[])
-        ])
+            DWARFExprOp(op=0xe0, op_name='DW_OP_lo_user', args=[])])
 
 
 if __name__ == '__main__':