From: Simon Marchi <simon.marchi@polymtl.ca>
Date: Fri, 2 Dec 2022 20:09:23 +0000 (-0500)
Subject: gdb/linux-nat: check ptrace return value in linux_nat_get_siginfo
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=7cc662bcb70fc4eb5a7b5883fd27fab0d4e372cb;p=binutils-gdb.git

gdb/linux-nat: check ptrace return value in linux_nat_get_siginfo

Not a big deal, but it seems strange to check errno instead of the
ptrace return value to know whether it succeeded.

Change-Id: If0a6d0280ab0e5ecb077e546af0d6fe489c5b9fd
---

diff --git a/gdb/linux-nat.c b/gdb/linux-nat.c
index c47b8db9299..b33fac3d149 100644
--- a/gdb/linux-nat.c
+++ b/gdb/linux-nat.c
@@ -4443,11 +4443,7 @@ bool
 linux_nat_get_siginfo (ptid_t ptid, siginfo_t *siginfo)
 {
   int pid = get_ptrace_pid (ptid);
-
-  errno = 0;
-  ptrace (PTRACE_GETSIGINFO, pid, (PTRACE_TYPE_ARG3) 0, siginfo);
-
-  return errno == 0;
+  return ptrace (PTRACE_GETSIGINFO, pid, (PTRACE_TYPE_ARG3) 0, siginfo) == 0;
 }
 
 /* See nat/linux-nat.h.  */