From: Paul Berry <stereotype441@gmail.com>
Date: Fri, 25 Jan 2013 00:11:08 +0000 (-0800)
Subject: glsl: Clean up case statement in builtin_variables.cpp's add_variable.
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=7d51ead56e2b97d313c6a0fda22cc930b5c41e9d;p=mesa.git

glsl: Clean up case statement in builtin_variables.cpp's add_variable.

The case statement purported to handle the addition of ir_var_const_in
and ir_var_inout builtin variables.  But no such variables exist.
This patch removes the unnecessary cases, and adds a comment
explaining why they're not needed.

Reviewed-by: Carl Worth <cworth@cworth.org>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Eric Anholt <eric@anholt.net>
---

diff --git a/src/glsl/builtin_variables.cpp b/src/glsl/builtin_variables.cpp
index e7769419f61..f2a804986cd 100644
--- a/src/glsl/builtin_variables.cpp
+++ b/src/glsl/builtin_variables.cpp
@@ -404,15 +404,17 @@ add_variable(exec_list *instructions, glsl_symbol_table *symtab,
    switch (var->mode) {
    case ir_var_auto:
    case ir_var_in:
-   case ir_var_const_in:
    case ir_var_uniform:
    case ir_var_system_value:
       var->read_only = true;
       break;
-   case ir_var_inout:
    case ir_var_out:
       break;
    default:
+      /* The only variables that are added using this function should be
+       * uniforms, shader inputs, and shader outputs, constants (which use
+       * ir_var_auto), and system values.
+       */
       assert(0);
       break;
    }