From: Gabe Black Date: Fri, 12 Oct 2018 00:57:20 +0000 (-0700) Subject: dev: Build the PCI device models even in NULL_ISA builds. X-Git-Tag: v19.0.0.0~1480 X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=7d719bc81191f74149fabf536a0cfc573c172a26;p=gem5.git dev: Build the PCI device models even in NULL_ISA builds. There are some minor ISA dependencies in the PCI device models, specifically that they use the set<> accessors on the packet objects. This actually compiles fine because the NULL ISA claims to be little endian, but really these accessors should be changed to use little endian all the time since that's what PCI is defined to use, not the guest endianness. The other types of accessors, specifically the ones that default to what the guest wants, should be excluded when building NULL_ISA, and, pending other dependencies, the NULL_ISA should no longer have an endianness associated with it. Change-Id: I0739122dbf67d109e7959553a1eff0239b090ca4 Reviewed-on: https://gem5-review.googlesource.com/c/13468 Reviewed-by: Andreas Sandberg Maintainer: Andreas Sandberg --- diff --git a/src/dev/pci/SConscript b/src/dev/pci/SConscript index 2c48403f8..56c06dda5 100644 --- a/src/dev/pci/SConscript +++ b/src/dev/pci/SConscript @@ -44,9 +44,6 @@ Import('*') -if env['TARGET_ISA'] == 'null': - Return() - SimObject('PciDevice.py') Source('device.cc') DebugFlag('PciDevice')