From: Isaac Sánchez Barrera <isaac.sanchez@bsc.es>
Date: Fri, 15 Nov 2019 15:17:23 +0000 (+0100)
Subject: mem-cache: Initialize all members of `QueuedPrefetcher::DeferredPacket`.
X-Git-Tag: v19.0.0.0~292
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=7e19b26f503435f07dc4b5675061facc521b8c91;p=gem5.git

mem-cache: Initialize all members of `QueuedPrefetcher::DeferredPacket`.

Members `tc` and `ongoingTranslation` were uninitialized in the constructor for
`QueuedPrefetcher::DeferredPacket`. If `ongoingTranslation` is not initialized to
`false` by default, some translation requests from queued prefetchers are not
properly handled and executions are nondeterministic.

Change-Id: Ia278f9e74847d6b847984d47f6a45643bae57794
Signed-off-by: Isaac Sánchez Barrera <isaac.sanchez@bsc.es>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/22844
Reviewed-by: Nikos Nikoleris <nikos.nikoleris@arm.com>
Maintainer: Nikos Nikoleris <nikos.nikoleris@arm.com>
Tested-by: kokoro <noreply+kokoro@google.com>
---

diff --git a/src/mem/cache/prefetch/queued.hh b/src/mem/cache/prefetch/queued.hh
index ae4c5e4ad..adcd255ba 100644
--- a/src/mem/cache/prefetch/queued.hh
+++ b/src/mem/cache/prefetch/queued.hh
@@ -80,7 +80,8 @@ class QueuedPrefetcher : public BasePrefetcher
          */
         DeferredPacket(QueuedPrefetcher *o, PrefetchInfo const &pfi, Tick t,
             int32_t prio) : owner(o), pfInfo(pfi), tick(t), pkt(nullptr),
-            priority(prio), translationRequest() {
+            priority(prio), translationRequest(), tc(nullptr),
+            ongoingTranslation(false) {
         }
 
         bool operator>(const DeferredPacket& that) const