From: Mark Kettenis Date: Sun, 30 May 2004 14:13:49 +0000 (+0000) Subject: * i386-tdep.c (i386_supply_gregset): Adjust comment. X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=7fdafb5ae3c444d3874cd33748d9b1469d631d7e;p=binutils-gdb.git * i386-tdep.c (i386_supply_gregset): Adjust comment. (i386_collect_gregset): New function. (i386_supply_fpregset): Adjust comment. (i386_collect_fpregset): New function. (i386_regset_from_core_section): Use i386_collect_gregset and i386_collect_fpregset. --- diff --git a/gdb/ChangeLog b/gdb/ChangeLog index f6c21d87ded..c99357485f8 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,12 @@ 2004-05-30 Mark Kettenis + * i386-tdep.c (i386_supply_gregset): Adjust comment. + (i386_collect_gregset): New function. + (i386_supply_fpregset): Adjust comment. + (i386_collect_fpregset): New function. + (i386_regset_from_core_section): Use i386_collect_gregset and + i386_collect_fpregset. + * hppa-tdep.c (hppa_frame_prev_register_helper): Reimplement to handle VALUEP being null. diff --git a/gdb/i386-tdep.c b/gdb/i386-tdep.c index 3b9ce9c027e..a3c5afec044 100644 --- a/gdb/i386-tdep.c +++ b/gdb/i386-tdep.c @@ -1608,9 +1608,9 @@ i386_value_to_register (struct frame_info *frame, int regnum, } } -/* Supply register REGNUM from the general-purpose register set REGSET - to register cache REGCACHE. If REGNUM is -1, do this for all - registers in REGSET. */ +/* Supply register REGNUM from the buffer specified by GREGS and LEN + in the general-purpose register set REGSET to register cache + REGCACHE. If REGNUM is -1, do this for all registers in REGSET. */ void i386_supply_gregset (const struct regset *regset, struct regcache *regcache, @@ -1630,9 +1630,33 @@ i386_supply_gregset (const struct regset *regset, struct regcache *regcache, } } -/* Supply register REGNUM from the floating-point register set REGSET - to register cache REGCACHE. If REGNUM is -1, do this for all - registers in REGSET. */ +/* Collect register REGNUM from the register cache REGCACHE and store + it in the buffer specified by GREGS and LEN as described by the + general-purpose register set REGSET. If REGNUM is -1, do this for + all registers in REGSET. */ + +void +i386_collect_gregset (const struct regset *regset, + const struct regcache *regcache, + int regnum, void *gregs, size_t len) +{ + const struct gdbarch_tdep *tdep = gdbarch_tdep (regset->arch); + char *regs = gregs; + int i; + + gdb_assert (len == tdep->sizeof_gregset); + + for (i = 0; i < tdep->gregset_num_regs; i++) + { + if ((regnum == i || regnum == -1) + && tdep->gregset_reg_offset[i] != -1) + regcache_raw_collect (regcache, i, regs + tdep->gregset_reg_offset[i]); + } +} + +/* Supply register REGNUM from the buffer specified by FPREGS and LEN + in the floating-point register set REGSET to register cache + REGCACHE. If REGNUM is -1, do this for all registers in REGSET. */ static void i386_supply_fpregset (const struct regset *regset, struct regcache *regcache, @@ -1650,6 +1674,27 @@ i386_supply_fpregset (const struct regset *regset, struct regcache *regcache, i387_supply_fsave (regcache, regnum, fpregs); } +/* Supply register REGNUM from the buffer specified by FPREGS and LEN + in the floating-point register set REGSET to register cache + REGCACHE. If REGNUM is -1, do this for all registers in REGSET. */ + +static void +i386_collect_fpregset (const struct regset *regset, + const struct regcache *regcache, + int regnum, void *fpregs, size_t len) +{ + const struct gdbarch_tdep *tdep = gdbarch_tdep (regset->arch); + + if (len == I387_SIZEOF_FXSAVE) + { + i387_collect_fxsave (regcache, regnum, fpregs); + return; + } + + gdb_assert (len == tdep->sizeof_fpregset); + i387_collect_fsave (regcache, regnum, fpregs); +} + /* Return the appropriate register set for the core section identified by SECT_NAME and SECT_SIZE. */ @@ -1662,7 +1707,8 @@ i386_regset_from_core_section (struct gdbarch *gdbarch, if (strcmp (sect_name, ".reg") == 0 && sect_size == tdep->sizeof_gregset) { if (tdep->gregset == NULL) - tdep->gregset = regset_alloc (gdbarch, i386_supply_gregset, NULL); + tdep->gregset = regset_alloc (gdbarch, i386_supply_gregset, + i386_collect_gregset); return tdep->gregset; } @@ -1671,7 +1717,8 @@ i386_regset_from_core_section (struct gdbarch *gdbarch, && sect_size == I387_SIZEOF_FXSAVE)) { if (tdep->fpregset == NULL) - tdep->fpregset = regset_alloc (gdbarch, i386_supply_fpregset, NULL); + tdep->fpregset = regset_alloc (gdbarch, i386_supply_fpregset, + i386_collect_fpregset); return tdep->fpregset; }