From: Lancelot SIX <lsix@lancelotsix.com>
Date: Sun, 1 Aug 2021 15:47:29 +0000 (+0000)
Subject: gdb: Use unwinder name in frame_info::to_string
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=8085fa01a57e356aa1b91d30f89f6146ee1928c1;p=binutils-gdb.git

gdb: Use unwinder name in frame_info::to_string

While working on a stack unwinding issue using 'set debug frame on', I
noticed the frame_info::to_string method could be slightly improved.

Unwinders have been given a name in
a154d838a70e96d888620c072e2d6ea8bdf044ca.  Before this patch, frame_info
debug output prints the host address of the used unwinder, which is not
easy to interpret.  This patch proposes to use the unwinder name
instead since we now have it.

Before the patch:

    {level=1,type=NORMAL_FRAME,unwind=0x2ac1763ec0,pc=0x3ff7fc3460,id={stack=0x3ff7ea79b0,code=0x0000003ff7fc33ac,!special},func=0x3ff7fc33ac}

With the patch:

    {level=1,type=NORMAL_FRAME,unwinder="riscv prologue",pc=0x3ff7fc3460,id={stack=0x3ff7ea79b0,code=0x0000003ff7fc33ac,!special},func=0x3ff7fc33ac}

Tested on riscv64-linux-gnu.
---

diff --git a/gdb/frame.c b/gdb/frame.c
index 2332418f347..4d7505f7ae3 100644
--- a/gdb/frame.c
+++ b/gdb/frame.c
@@ -467,9 +467,9 @@ frame_info::to_string () const
     res += "type=<unknown>,";
 
   if (fi->unwind != NULL)
-    res += string_printf ("unwind=%p,", host_address_to_string (fi->unwind));
+    res += string_printf ("unwinder=\"%s\",", fi->unwind->name);
   else
-    res += "unwind=<unknown>,";
+    res += "unwinder=<unknown>,";
 
   if (fi->next == NULL || fi->next->prev_pc.status == CC_UNKNOWN)
     res += "pc=<unknown>,";