From: Tom de Vries <tdevries@suse.de>
Date: Fri, 12 Jun 2020 16:36:56 +0000 (+0200)
Subject: [gdbserver] Fix Wlto-type-mismatch for debug_agent
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=8118159c69a957292ce701b3d2937f19a0d0f973;p=binutils-gdb.git

[gdbserver] Fix Wlto-type-mismatch for debug_agent

When building gdb including gdbserver with CFLAGS/CXXFLAGS -O2 -g -flto=auto,
I run into:
...
src/gdbserver/../gdbsupport/agent.h:47:13: error: type of 'debug_agent' \
  does not match original declaration [-Werror=lto-type-mismatch]
 extern bool debug_agent;
             ^
src/gdbserver/ax.cc:28:5: note: type 'int' should match type 'bool'
 int debug_agent = 0;
     ^
src/gdbserver/ax.cc:28:5: note: 'debug_agent' was previously declared here
src/gdbserver/ax.cc:28:5: note: code may be misoptimized unless \
  -fno-strict-aliasing is used
...

Fix this by changing the type of debug_agent in ax.cc from int to bool.

Tested on x86_64-linux.
---

diff --git a/gdbserver/ax.cc b/gdbserver/ax.cc
index 213db410a07..42d28128fa6 100644
--- a/gdbserver/ax.cc
+++ b/gdbserver/ax.cc
@@ -25,7 +25,7 @@
 static void ax_vdebug (const char *, ...) ATTRIBUTE_PRINTF (1, 2);
 
 #ifdef IN_PROCESS_AGENT
-int debug_agent = 0;
+bool debug_agent = 0;
 #endif
 
 static void