From: Alan Modra <amodra@gmail.com>
Date: Wed, 11 Mar 2020 12:29:07 +0000 (+1030)
Subject: asan: som: unknown read
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=8248d21a5b8b7bb9970163b8b327f5ac2f857f33;p=binutils-gdb.git

asan: som: unknown read

	* som.c (setup_sections): Sanity check subspace.name.
---

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index c60fe8c7f93..3b252e11968 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,7 @@
+2020-03-11  Alan Modra  <amodra@gmail.com>
+
+	* som.c (setup_sections): Sanity check subspace.name.
+
 2020-03-11  Alan Modra  <amodra@gmail.com>
 
 	* elf64-ppc.c (ppc64_elf_inline_plt): Do increment rel in for loop.
diff --git a/bfd/som.c b/bfd/som.c
index 3aa3d60b02b..5676f0f5008 100644
--- a/bfd/som.c
+++ b/bfd/som.c
@@ -2197,6 +2197,9 @@ setup_sections (bfd *abfd,
 	  som_swap_subspace_dictionary_in (&ext_subspace, &subspace);
 
 	  /* Setup the subspace name string.  */
+	  if (subspace.name >= file_hdr->space_strings_size)
+	    goto error_return;
+
 	  subspace_name = subspace.name + space_strings;
 
 	  amt = strlen (subspace_name) + 1;