From: Gary Benson <gbenson@redhat.com>
Date: Fri, 1 Mar 2019 13:50:27 +0000 (+0000)
Subject: Fix coff_start_symtab resource leak found by Coverity
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=827f438f664809b13ea59e8fabc43070dbd17645;p=binutils-gdb.git

Fix coff_start_symtab resource leak found by Coverity

This commit fixes a resource leak found by Coverity, where
coff_start_symtab performs an xstrdup that is now performed
within start_symtab by buildsym_compunit::buildsym_compunit.

gdb/ChangeLog:

	* coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
---

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index f7d86202494..da1890a32d5 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2019-03-01  Gary Benson <gbenson@redhat.com>
+
+	* coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
+
 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
 	    Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 
diff --git a/gdb/coffread.c b/gdb/coffread.c
index 6381cd3f370..91a112e190d 100644
--- a/gdb/coffread.c
+++ b/gdb/coffread.c
@@ -385,10 +385,7 @@ coff_start_symtab (struct objfile *objfile, const char *name)
 {
   within_function = 0;
   start_symtab (objfile,
-  /* We fill in the filename later.  start_symtab puts this pointer
-     into last_source_file and we put it in subfiles->name, which
-     end_symtab frees; that's why it must be malloc'd.  */
-		 xstrdup (name),
+		name,
   /* We never know the directory name for COFF.  */
 		 NULL,
   /* The start address is irrelevant, since we call