From: Simon Marchi <simon.marchi@polymtl.ca>
Date: Sun, 27 Nov 2016 03:05:25 +0000 (-0500)
Subject: Fix return value of uo_redirect
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=82bbe65a43015a753bec8c64869679a699331a5b;p=binutils-gdb.git

Fix return value of uo_redirect

The wrapper uo_redirect seems like it should return the return value
from of implementation function, since callers rely on it, but it
doesn't.

gdb/ChangeLog:

	* ui-out.c (uo_redirect): Return the return value from the
	implementation function.
---

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 21d10c4be3e..d6d5dc65546 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2016-11-26  Simon Marchi  <simon.marchi@polymtl.ca>
+
+	* ui-out.c (uo_redirect): Return the return value from the
+	implementation function.
+
 2016-11-26  Simon Marchi  <simon.marchi@polymtl.ca>
 
 	* ui-out.c (ui_out_destroy, uo_data_destroy): Remove.
diff --git a/gdb/ui-out.c b/gdb/ui-out.c
index 407c349ebe5..7f365457d25 100644
--- a/gdb/ui-out.c
+++ b/gdb/ui-out.c
@@ -703,8 +703,7 @@ uo_redirect (struct ui_out *uiout, struct ui_file *outstream)
 {
   if (!uiout->impl->redirect)
     return -1;
-  uiout->impl->redirect (uiout, outstream);
-  return 0;
+  return uiout->impl->redirect (uiout, outstream);
 }
 
 /* local functions */