From: Luke Kenneth Casson Leighton <lkcl@lkcl.net>
Date: Wed, 27 Mar 2019 13:55:35 +0000 (+0000)
Subject: lost removal of result intermediary from UnbufferedPipeline
X-Git-Tag: ls180-24jan2020~1468
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=8624a8f2cf7b7c81de2fb9e4184586e7ba6d477c;p=ieee754fpu.git

lost removal of result intermediary from UnbufferedPipeline

combinatorial result intermediary not necessary, was removed earlier
and got restored accidentally when reverting array-based pipeline
---

diff --git a/src/add/singlepipe.py b/src/add/singlepipe.py
index dabc7fcd..995ea21f 100644
--- a/src/add/singlepipe.py
+++ b/src/add/singlepipe.py
@@ -598,20 +598,18 @@ class UnbufferedPipeline(ControlBase):
         m = Module()
 
         r_data = self.stage.ispec() # input type
-        result = self.stage.ospec() # output data
         if hasattr(self.stage, "setup"):
             self.stage.setup(m, r_data)
 
         p_i_valid = Signal(reset_less=True)
         m.d.comb += p_i_valid.eq(self.p.i_valid_logic())
-        m.d.comb += eq(result, self.stage.process(r_data))
         m.d.comb += self.n.o_valid.eq(self._data_valid)
         m.d.comb += self.p.o_ready.eq(~self._data_valid | self.n.i_ready)
         m.d.sync += self._data_valid.eq(p_i_valid | \
                                         (~self.n.i_ready & self._data_valid))
         with m.If(self.p.i_valid & self.p.o_ready):
             m.d.sync += eq(r_data, self.p.i_data)
-        m.d.comb += eq(self.n.o_data, result)
+        m.d.comb += eq(self.n.o_data, self.stage.process(r_data))
         return m