From: Emil Velikov <emil.l.velikov@gmail.com>
Date: Sun, 29 Nov 2015 11:48:26 +0000 (+0000)
Subject: st/va: add missing break statement
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=866a1f7fddcf38c0cd40fc7b9509e562353e1acc;p=mesa.git

st/va: add missing break statement

Earlier commit factored out the mpeg4 IQ matrix handling into separate
function, although it forgot to add a break in its case statement.
Thus the data ended up partially overwritten as the mpeg4 and h265
structs are members of the desc union.

Spotted by Coverity (CID 1341052)

Fixes: 64761a841db "st/va: move MPEG4 functions into separate file"
Cc: Julien Isorce <j.isorce@samsung.com>
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
---

diff --git a/src/gallium/state_trackers/va/picture.c b/src/gallium/state_trackers/va/picture.c
index 5f703eb3eb6..34e7d553d1b 100644
--- a/src/gallium/state_trackers/va/picture.c
+++ b/src/gallium/state_trackers/va/picture.c
@@ -281,6 +281,7 @@ handleIQMatrixBuffer(vlVaContext *context, vlVaBuffer *buf)
 
    case PIPE_VIDEO_FORMAT_MPEG4:
       vlVaHandleIQMatrixBufferMPEG4(context, buf);
+      break;
 
    case PIPE_VIDEO_FORMAT_HEVC:
       assert(buf->size >= sizeof(VAIQMatrixBufferH264) && buf->num_elements == 1);