From: Nicolai Hähnle Date: Tue, 6 Dec 2016 20:03:03 +0000 (+0100) Subject: radeonsi: fix an off-by-one error in the bounds check for max_vertices X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=88509518b01d7c1d7436a790bf9be5cf3c41a528;p=mesa.git radeonsi: fix an off-by-one error in the bounds check for max_vertices The spec actually says that calling EmitStreamVertex is undefined when you exceed max_vertices. But we do need to avoid trampling over memory outside the GSVS ring. Cc: mesa-stable@lists.freedesktop.org Reviewed-by: Edward O'Callaghan Reviewed-by: Michel Dänzer Reviewed-by: Marek Olšák --- diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 8827643caef..9ee1190b9e9 100644 --- a/src/gallium/drivers/radeonsi/si_shader.c +++ b/src/gallium/drivers/radeonsi/si_shader.c @@ -5281,7 +5281,7 @@ static void si_llvm_emit_vertex( * further memory loads and may allow LLVM to skip to the end * altogether. */ - can_emit = LLVMBuildICmp(gallivm->builder, LLVMIntULE, gs_next_vertex, + can_emit = LLVMBuildICmp(gallivm->builder, LLVMIntULT, gs_next_vertex, lp_build_const_int32(gallivm, shader->selector->gs_max_out_vertices), "");