From: Robert Foss <robert.foss@collabora.com>
Date: Thu, 2 Mar 2017 00:14:39 +0000 (-0500)
Subject: mesa: Avoid read of uninitialized variable
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=88becf73022d780cfd0d7dbc5bb3911f8b0d2b11;p=mesa.git

mesa: Avoid read of uninitialized variable

The is_color_attachement variable is later read when handling two
separate error cases, where only one of the cases results in the
variable being initialized.

This can be avoided by giving the variable a safe default value.

Coverity-Id: 1398631
Cc: mesa-stable@lists.freedesktop.org
Signed-off-by: Robert Foss <robert.foss@collabora.com>
Reviewed-by: Ilia Mirkin <imirkin@alum.mit.edu>
Reviewed-by: Anuj Phogat <anuj.phogat@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
---

diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c
index c8ec8e68a19..f73a009d626 100644
--- a/src/mesa/main/fbobject.c
+++ b/src/mesa/main/fbobject.c
@@ -3684,7 +3684,7 @@ _mesa_get_framebuffer_attachment_parameter(struct gl_context *ctx,
                                            GLint *params, const char *caller)
 {
    const struct gl_renderbuffer_attachment *att;
-   bool is_color_attachment;
+   bool is_color_attachment = false;
    GLenum err;
 
    /* The error code for an attachment type of GL_NONE differs between APIs.