From: Gabe Black Date: Fri, 22 Nov 2019 23:35:28 +0000 (-0800) Subject: sim: Small style fixes in sim/syscall_return.hh. X-Git-Tag: v19.0.0.0~230 X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=89d50b0c9291f62aa8ffeac56ef277d5ee688adb;p=gem5.git sim: Small style fixes in sim/syscall_return.hh. Jira Issue: https://gem5.atlassian.net/browse/GEM5-187 Change-Id: I485004843393c2e10c1ff4dbd84fc30ca4fd490c Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/23165 Reviewed-by: Gabe Black Maintainer: Gabe Black Tested-by: kokoro --- diff --git a/src/sim/syscall_return.hh b/src/sim/syscall_return.hh index 1d531daac..b2e324827 100644 --- a/src/sim/syscall_return.hh +++ b/src/sim/syscall_return.hh @@ -68,7 +68,8 @@ class SyscallReturn {} /// Pseudo-constructor to create an instance with the retry flag set. - static SyscallReturn retry() + static SyscallReturn + retry() { SyscallReturn s(0); s.retryFlag = true; @@ -78,7 +79,8 @@ class SyscallReturn ~SyscallReturn() {} /// Was the system call successful? - bool successful() const + bool + successful() const { return (value >= 0 || value <= -4096); } @@ -87,27 +89,25 @@ class SyscallReturn bool needsRetry() const { return retryFlag; } /// The return value - int64_t returnValue() const + int64_t + returnValue() const { assert(successful()); return value; } /// The errno value - int errnoValue() const + int + errnoValue() const { assert(!successful()); return -value; } /// The encoded value (as described above) - int64_t encodedValue() const - { - return value; - } + int64_t encodedValue() const { return value; } private: - int64_t value; bool retryFlag;