From: Kenneth Graunke Date: Tue, 12 Feb 2019 06:36:45 +0000 (-0800) Subject: iris: Drop XXX about checking for swizzling X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=8ab82bd1fd945185de570c6853002d66d4efbbac;p=mesa.git iris: Drop XXX about checking for swizzling Caio noted that this is not necessary on Gen8+: "Before Gen8, there was a historical configuration control field to swizzle address bit[6] for in X/Y tiling modes. This was set in three different places: TILECTL[1:0], ARB_MODE[5:4], and DISP_ARB_CTL[14:13]. For Gen8 and subsequent generations, the swizzle fields are all reserved, and the CPU's memory controller performs all address swizzling modifications." Since we don't support earlier hardware, we can skip it entirely. --- diff --git a/src/gallium/drivers/iris/iris_screen.c b/src/gallium/drivers/iris/iris_screen.c index 728c2c23506..89f6f1bb85e 100644 --- a/src/gallium/drivers/iris/iris_screen.c +++ b/src/gallium/drivers/iris/iris_screen.c @@ -574,8 +574,7 @@ iris_screen_create(int fd) screen->precompile = env_var_as_boolean("shader_precompile", true); - bool hw_has_swizzling = false; // XXX: detect? - isl_device_init(&screen->isl_dev, &screen->devinfo, hw_has_swizzling); + isl_device_init(&screen->isl_dev, &screen->devinfo, false); screen->compiler = brw_compiler_create(screen, &screen->devinfo); screen->compiler->shader_debug_log = iris_shader_debug_log;